[pkg-fso-maint] install.sh: various minor corrections

[Luca Capello]

Hi Brian!

Please always reply to the pkg-fso-maint@ mailing list, since everything
is discussed there (no need to cc: me, I read the list).

On Tue, 16 Jun 2009 02:29:20 +0200, Brian DeRocher wrote:
> On Mon 2009 Jun 15 12:06 you wrote:
>> On Sun, 14 Jun 2009 22:09:36 +0200, Brian DeRocher wrote:
>> > Likewise, line 695 can be re-factored, no bug there though.
>>
>> Please better explain, maybe with a diff, what you are referring to: I
>> do not see how the code below can be refactored...
>
> not tested
>
> diff --git a/install.sh b/install.sh
> index 515eea8..bff3e9b 100755
> --- a/install.sh
> +++ b/install.sh
> @@ -690,10 +690,9 @@ EOSWAPCONF
>
>         echo " * Waiting for partitions to appear"
>         intern_sleep_seconds=3
> -       if [ "$SINGLE_PART" = "true" ]; then
> -               intern_devtest="test -e ${SD_DEVICE}p1"
> -       else
> -               intern_devtest="test -e ${SD_DEVICE}p1 -a -e ${SD_DEVICE}p2"
> +       intern_devtest="test -e ${SD_DEVICE}p1"
> +       if [ "$SINGLE_PART" != "true" ]; then
> +               intern_devtest="${intern_dev_test} -a -e ${SD_DEVICE}p2"
>         fi
>
>         while ! $intern_devtest; do

I do not see any gain in this change and, on the contrary and at least
IMHO, it renders the code more difficult when reading it.  Nevertheless,
if anyone confirms that your patch works and we do not have any
regression, I will be apply it.

BTW, since you now use Git, if you provide full Git patches:

  $ git commit ...
  $ git format-patch origin/HEAD
  $ git send-email ...

it will be easier to test/apply them (and you will figure as the author
patch on `git log`).

Thx, bye,
Gismo / Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 314 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20090616/2a347a6e/attachment.pgp>