[pkg-fso-maint] [RFR] templates://libphone-utils/{libphone-utils0.templates}

[Justin B Rye]

Christian PERRIER wrote:
> Your review should be sent as an answer to this mail.

The templates look good; I've only got comments on the boilerplate
section of the package descriptions.

>   This library contains basic functions needed by SHR
>   phone software and FSO opimd daemon.
>   .
>   The library is used for handling international numbers.

Expanding SHR (to "Stable Hybrid Release") wouldn't help much, but
can we say "and the FreeSmartphone.Org opimd daemon"?

And then if the second paragraph is talking about the same library
then the sentence should probably start with "It".  I'd also merge
them into one boilerplate paragraph - or even one sentence, but
this'll do: 

    This library contains basic functions needed by SHR phone software
    and the FreeSmartphone.Org opimd daemon. It is used for handling
    international numbers.

-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
-------------- next part --------------
--- ../libphone-utils-0.1+git20091114.pristine/debian/libphone-utils0.templates	2009-12-29 18:58:10.000000000 +0000
+++ debian/libphone-utils0.templates	2010-01-03 10:56:26.000000000 +0000
@@ -1,29 +1,29 @@
 Template: libphone-utils/international_prefix
 Type: string
 Default: 00
-_Description: international phone prefix:
- You can setup the prefix for international calls here.
- This prefix is "00" in a lot of countries.
+_Description: International phone prefix:
+ Please enter the prefix to dial for international calls.
+ This prefix is "00" in most countries.
 
 Template: libphone-utils/national_prefix
 Type: string
 Default: 0
-_Description: national phone prefix:
- You can setup the prefix for national calls here.
- This prefix is "0" in a lot of countries.
+_Description: National phone prefix:
+ Please enter the prefix to dial for national calls.
+ This prefix is "0" in most countries.
 
 Template: libphone-utils/country_code
 Type: string
-Default: 49
-_Description: country code:
- You can setup your country code here.
- For example it is "49" for Germany.
+_Defaultchoice: 49
+_Description: Telephone country code:
+ Please enter the international telephone code for the local country
+ (for instance, "49" for Germany).
 
 Template: libphone-utils/area_code
 Type: string
 Default: 0
-_Description: area code:
- You can setup your area code here.
- For example it is "30" for Berlin.
- This is normally only needed with
- landline phones.
+_Description: Area code:
+ Please enter the telephone code for the local area (for instance,
+ "30" for Berlin in Germany).
+ .
+ This is normally only needed with landline phones.
--- ../libphone-utils-0.1+git20091114.pristine/debian/control	2009-12-29 18:58:10.000000000 +0000
+++ debian/control	2010-01-03 10:57:46.000000000 +0000
@@ -15,10 +15,9 @@
 Depends: ${shlibs:Depends},
          ${misc:Depends}
 Description: library for basic phone operations
- This library contains basic functions needed by SHR
- phone software and FSO opimd daemon.
- .
- The library is used for handling international numbers.
+ This library contains basic functions needed by SHR phone software
+ and the FreeSmartphone.Org opimd daemon. It is used for handling
+ international numbers.
 
 Package: libphone-utils0-dbg
 Section: debug
@@ -26,13 +25,12 @@
 Depends: libphone-utils0 (= ${binary:Version}),
          ${shlibs:Depends},
          ${misc:Depends}
-Description: library for basic phone operations (debug symbols)
- This library contains basic functions needed by SHR
- phone software and FSO opimd daemon.
- .
- The library is used for handling international numbers.
+Description: library for basic phone operations - debug symbols
+ This library contains basic functions needed by SHR phone software
+ and the FreeSmartphone.Org opimd daemon. It is used for handling
+ international numbers.
  .
- This library contains the debug symbols for the library.
+ This package provides the debug symbols for the library.
 
 Package: libphone-utils-dev
 Section: libdevel
@@ -41,10 +39,9 @@
          ${shlibs:Depends},
          ${misc:Depends},
          libglib2.0-dev
-Description: library for basic phone operations (devel files)
- This library contains basic functions needed by SHR
- phone software and FSO opimd daemon.
- .
- The library is used for handling international numbers.
+Description: library for basic phone operations - development files
+ This library contains basic functions needed by SHR phone software
+ and the FreeSmartphone.Org opimd daemon. It is used for handling
+ international numbers.
  .
- This package contains the development files for this library.
+ This package provides the development files for this library.
-------------- next part --------------
Source: libphone-utils
Section: libs
Priority: extra
Maintainer: Debian freesmartphone.org Team <pkg-fso-maint at lists.alioth.debian.org>
Uploaders: Sebastian Reichel <elektranox at gmail.com>
Build-Depends: cdbs,
               debhelper (>= 7),
               libglib2.0-dev,
               po-debconf
Standards-Version: 3.8.3
Homepage: http://shr-project.org

Package: libphone-utils0
Architecture: any
Depends: ${shlibs:Depends},
         ${misc:Depends}
Description: library for basic phone operations
 This library contains basic functions needed by SHR phone software
 and the FreeSmartphone.Org opimd daemon. It is used for handling
 international numbers.

Package: libphone-utils0-dbg
Section: debug
Architecture: any
Depends: libphone-utils0 (= ${binary:Version}),
         ${shlibs:Depends},
         ${misc:Depends}
Description: library for basic phone operations - debug symbols
 This library contains basic functions needed by SHR phone software
 and the FreeSmartphone.Org opimd daemon. It is used for handling
 international numbers.
 .
 This package provides the debug symbols for the library.

Package: libphone-utils-dev
Section: libdevel
Architecture: any
Depends: libphone-utils0 (= ${binary:Version}),
         ${shlibs:Depends},
         ${misc:Depends},
         libglib2.0-dev
Description: library for basic phone operations - development files
 This library contains basic functions needed by SHR phone software
 and the FreeSmartphone.Org opimd daemon. It is used for handling
 international numbers.
 .
 This package provides the development files for this library.