[pkg-fso-maint] Bug#861771: Fails to install: postinst script returned error exit status 1

[Simon McVittie]

Control: found 861771 0.13-1
Control: tags 861771 + patch

On Mon, 08 May 2017 at 20:14:28 +0100, Simon McVittie wrote:
> If you try to downgrade to 0.13-1 (in testing), do you still get this?

I can reproduce this with 0.13-1, so it should not block migration.

> I think the attached patch should hopefully fix this bug (thanks to
> Ansgar Burchardt for suggesting this approach)

This doesn't work: if an ExecStartPre command exits with the
SuccessExitStatus then systemd proceeds to ExecStart, so I don't think
we can have an ExecStartPre that cancels start without marking the service
as failed (which would in turn make the postinst fragment fail). But it
can be adapted by using a non-trivial ExecStartPre, as in the attached.

The long-term solution would be to not enable the display manager at
the update-rc.d level) if it wasn't enabled by the user, and migrate
enabledness like this pseudocode:

    if (enabled, using the same algorithm as invoke-rc.d &&
        enabled in /etc/default/nodm) {
            update-rc.d nodm enable
    } else {
            update-rc.d nodm disable
    }

then remove NODM_ENABLED from /etc/default/nodm. openarena-server has
code in its preinst to do something similar.

But that definitely seems like a job for post-stretch, particularly
if it gets entangled with a new approach to registering for the
display-manager.service symlink (#852125).

    S
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nodm.service-Don-t-respawn-or-fail-if-disabled-in-et.patch
Type: text/x-diff
Size: 1017 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20170508/6e4f7faa/attachment.patch>