r9953 - packages/trunk/micropolis-activity/debian/patches

[Christoph Egger]

Author: christoph-guest
Date: 2009-07-02 19:43:58 +0000 (Thu, 02 Jul 2009)
New Revision: 9953

Modified:
   packages/trunk/micropolis-activity/debian/patches/fix-crash.patch
Log:
add description to patch

Modified: packages/trunk/micropolis-activity/debian/patches/fix-crash.patch
===================================================================
--- packages/trunk/micropolis-activity/debian/patches/fix-crash.patch	2009-07-02 19:30:00 UTC (rev 9952)
+++ packages/trunk/micropolis-activity/debian/patches/fix-crash.patch	2009-07-02 19:43:58 UTC (rev 9953)
@@ -1,3 +1,31 @@
+From: "Ying-Chun Liu (PaulLiu)" <grandpaul at gmail.com>
+To: 522529 at bugs.debian.org
+Subject: Re: micropolis: Segfault when loading scenarios
+Date: Thu, 25 Jun 2009 02:14:25 +0800
+
+Dear all,
+
+I think we have to fix all the warnings.
+
+C assumes all functions not defined the type of return values as integers.
+So a void function call without definition might get a stack pop by the caller which mess up the stack.
+However, normally it won't be that stupid, but
+it could be a compiler optimizer bug. So with -O0 or -O3, I don't get a crash.
+
+I've made a stupid patch which solves the crash at loading scenarios compiled by -O2. It just modify
+"return;" to "return 0;" around DoZone() and the function calls inside DoZone();
+
+Please try the attachment (quilt patch, last one in series).
+My arch is i386, not amd64.
+
+Yours Sincerely,
+Paul.
+
+-- 
+                                                PaulLiu(劉穎駿)
+E-mail address: grandpaul at gmail.com
+
+
 Index: micropolis-activity-0.0.20071228/src/sim/s_sim.c
 ===================================================================
 --- micropolis-activity-0.0.20071228.orig/src/sim/s_sim.c	2009-06-25 01:41:18.396541888 +0800