[game-data-packager] 01/01: engine recommendation: avoid duplicate calls to is_installed, readability

[Alexandre Detiste]

This is an automated email from the git hooks/post-receive script.

detiste-guest pushed a commit to branch master
in repository game-data-packager.

commit 393120d142a37b00c3b5bc330f1bcbdb9696a0e8
Author: Alexandre Detiste <alexandre.detiste at gmail.com>
Date:   Tue Mar 17 14:41:39 2015 +0100

    engine recommendation: avoid duplicate calls to is_installed, readability
---
 game_data_packager/__init__.py | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/game_data_packager/__init__.py b/game_data_packager/__init__.py
index 631acd9..12c884b 100644
--- a/game_data_packager/__init__.py
+++ b/game_data_packager/__init__.py
@@ -2061,16 +2061,15 @@ class GameData(object):
         if install_debs:
             self.install_packages(debs)
 
+        engines_alt = set((p.engine or self.engine) for p in ready)
+        engines_alt.discard(None)
         engines = set()
-        for package in ready:
-            engine = package.engine or self.engine
-            if not engine:
-                continue
-            for e in engine.split('|'):
-                if is_installed(e.split('(')[0].strip()):
+        for engine_alt in engines_alt:
+            for engine in reversed(engine_alt.split('|')):
+                engine = engine.split('(')[0].strip()
+                if is_installed(engine):
                     break
             else:
-                engine = engine.split('|')[0].split('(')[0].strip()
                 engines.add(engine)
         if engines:
             print('it is recommended to also install this game engine: %s' % ', '.join(engines))

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-games/game-data-packager.git