[game-data-packager] 01/01: GOG metadata: manual fixes + enhanced monitoring

[Alexandre Detiste]

This is an automated email from the git hooks/post-receive script.

detiste-guest pushed a commit to branch master
in repository game-data-packager.

commit ef8a9bc668b48827a7db57ee7728805aa5f166e7
Author: Alexandre Detiste <alexandre.detiste at gmail.com>
Date:   Mon May 1 11:51:54 2017 +0200

    GOG metadata: manual fixes + enhanced monitoring
    
    1) add integrity check between presence of 'gog:'  tags
     & 'setup_*.exe' archives
    
    2) disable GOG.com reference for Duke Nukem 3D:
     https://www.gog.com/news/weekly_staff_picks_farewell_for_now_duke
    
    3) catch up with changes in
        http://wiki.scummvm.org/index.php?title=Where_to_get_the_games&action=history
    
       add GOG id's for an handful of new games:
       - Freddy Pharkas
       - Iceman
       - Indiana Jones & The Last Crusade
       - Laura Bow 1 & 2
    
    4) add other missing games to GOG.com wishlist, this also includes:
       - Baldur's Gate
       - Elder Scrolls III: Morrowind
       - Heroes of Might & Magic III
    
    5) ... buy these games ... someday
    
    Other game owners can also run 'GDP_UNINSTALLED=1 python3 -m tools.gog_updated'
    and have a look a results.
---
 data/duke3d.yaml        |  8 ++++----
 data/freddypharkas.yaml |  2 ++
 data/iceman.yaml        |  2 ++
 data/last-crusade.yaml  |  2 ++
 data/laura-bow1.yaml    | 19 +++++--------------
 data/laura-bow2.yaml    |  2 ++
 tools/gog_updated.py    |  9 +++++++++
 7 files changed, 26 insertions(+), 18 deletions(-)

diff --git a/data/duke3d.yaml b/data/duke3d.yaml
index 582d849..2ddc307 100644
--- a/data/duke3d.yaml
+++ b/data/duke3d.yaml
@@ -29,10 +29,10 @@ packages:
       id: 225140
       path: common/Duke Nukem 3D/gameroot/classic
       native: true
-    gog:
-      url: duke_nukem_3d_atomic_edition
-      # banner at http://eduke32.com/
-      pp: 6c1e671f9af5b46d9c1a52067bdf0e53685674f7
+    #gog:
+    #  url: duke_nukem_3d_atomic_edition
+    #  # banner at http://eduke32.com/
+    #  pp: 6c1e671f9af5b46d9c1a52067bdf0e53685674f7
     url_misc: https://3drealms.com/catalog/duke-nukem-3d_27/
     install:
     - duke3d.grp
diff --git a/data/freddypharkas.yaml b/data/freddypharkas.yaml
index 24e0b94..cf174e8 100644
--- a/data/freddypharkas.yaml
+++ b/data/freddypharkas.yaml
@@ -7,6 +7,8 @@ wiki: Freddy_Pharkas
 packages:
   freddy-pharkas-cd-data:
     version: '1.000'
+    gog:
+      url: freddy_pharkas_frontier_pharmacist
     install:
     - cd assets
     - version
diff --git a/data/iceman.yaml b/data/iceman.yaml
index 246d882..75d19c0 100644
--- a/data/iceman.yaml
+++ b/data/iceman.yaml
@@ -7,6 +7,8 @@ wiki: "Codename:_ICEMAN"
 packages:
   iceman-data:
     version: '1.023'
+    gog:
+      url: codename_iceman
     install:
     - assets
 
diff --git a/data/last-crusade.yaml b/data/last-crusade.yaml
index 73bd58a..c2cb6a7 100644
--- a/data/last-crusade.yaml
+++ b/data/last-crusade.yaml
@@ -15,6 +15,8 @@ packages:
       id: 32310
       path: "common/Indiana Jones and the Last Crusade"
       #XXX: 00.lfl is included in "Indiana Jones and the Last Crusade.exe"
+    gog:
+      url: indiana_jones_and_the_last_crusade
     install:
     - 00.lfl
     - 01.lfl
diff --git a/data/laura-bow1.yaml b/data/laura-bow1.yaml
index 725cdd3..f97b56a 100644
--- a/data/laura-bow1.yaml
+++ b/data/laura-bow1.yaml
@@ -5,25 +5,16 @@ copyright: © 1989 Sierra
 plugin: scummvm_common
 gameid: laurabow
 wiki: Laura_Bow:_The_Colonel%27s_Bequest
+gog:
+  url: the_colonels_bequest
 
 packages:
   laura-bow1-data:
     install:
-    - resource.001
-    - resource.002
-    - resource.003
-    - resource.004
-    - resource.005
-    - resource.006
-    - resource.007
-    - resource.008
-    - resource.009
-    - resource.010
-    - resource.map
-    - script.052
-    - text.052
+    - assets
 
-size_and_md5: |
+groups:
+ assets: |
   108032    77cffb45b8a42f9f498b7a2962c2ca2b resource.001
   354680    4b05d2fea9ed95c8adc93e6abc5f3ace resource.002
   361815    226ef90743178bcac84dc53b8059dc29 resource.003
diff --git a/data/laura-bow2.yaml b/data/laura-bow2.yaml
index a17383b..425a97f 100644
--- a/data/laura-bow2.yaml
+++ b/data/laura-bow2.yaml
@@ -9,6 +9,8 @@ wiki: The_Dagger_of_Amon_Ra
 packages:
   laura-bow2-data:
     version: '1.1'
+    gog:
+      url: the_colonels_bequest
     optional:
     # squareish picture, could be converted in a .png icon
     - laurt.bmp
diff --git a/tools/gog_updated.py b/tools/gog_updated.py
index 65dfc32..e145fe6 100755
--- a/tools/gog_updated.py
+++ b/tools/gog_updated.py
@@ -36,14 +36,23 @@ def decode_filename(archive):
 print('# Reading data from YAML...')
 for name, game in load_games().items():
     game.load_file_data()
+    has_tags = has_archive = False
+    for package in game.packages.values():
+        gog = package.gog or game.gog
+        if 'url' in gog:
+            has_tags = True
     for filename,f in game.files.items():
         if filename.startswith('setup_') and filename.endswith('.exe'):
+            has_archive = True
             _, supported, version = decode_filename(filename)
             if '.' not in version:
                 # ancient GOG packages
                 continue
             if LooseVersion(version) > LooseVersion(yaml_files.get(supported, '0')):
                 yaml_files[supported] = version
+    if has_tags != has_archive:
+        print('GOG metadata not in sync for %s. (has_tags: %s, has_archive: %s)'
+              % (name, has_tags, has_archive))
 
 print('# Reading data from LGOGDOWNLOADER...')
 cache = os.path.expanduser('~/.cache/lgogdownloader/gamedetails.json')

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-games/game-data-packager.git