r3575 - packages/trunk/warsow/debian

Alexander Schmehl tolimar at debian.org
Tue Aug 7 14:07:23 UTC 2007


Hi Andres!

Two remarks about your recent warsow package:


* Alexander Schmehl <tolimar at alioth.debian.org> [070807 15:36]:
> Modified: packages/trunk/warsow/debian/changelog
[..]
> -  * Below is the changelog for the previous version which wasn't uploaded.
> -  [ 0.31.dfsg-5 changelog ]
> -  * Modified patch "fix_different_archs.diff".
> -    + Included line for Debian powerpc64 port.
> -    + Fixed powerpc CPUSTRING and ARCH to reflect uname -m output.
> -    + (Closes: 433671)
> -    + Fixed hppa CPUSTRING and ARCH to reflect uname -m on build machine.

You don't need to repeat the old changelog; you can use the -v option
for dpkg-buildpackage (or --debbuildopts -v... for pbuilder) to include
older changelog entries, too.


> Modified: packages/trunk/warsow/debian/control
[..]
>  Package: warsow
>  Architecture: any
> -Depends: ${shlibs:Depends}, mesa-utils, warsow-data (>= 0.31), warsow-data (<< 0.32)
> +Depends: ${shlibs:Depends}, mesa-utils, xbase-clients, warsow-data (>= 0.31), warsow-data (<< 0.32)

You use xmessage in the wrapper script, so you need to depend on the
package providing it, even if mesa-utils allready has such a dependency.
You can't be sure, that mesa-utils always will depend on the package.
Imagine mesa-utils drops it's dependency completly, or xbase-clients is
splitted in several packages, and mesa-utils depends on a subpackage not
containing xmessage.


Yours sincerely,
  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20070807/249d51b0/attachment.pgp 


More information about the Pkg-games-devel mailing list