r4509 - packages/trunk/xwelltris/debian

Gerfried Fuchs rhonda at deb.at
Thu Nov 1 03:29:03 UTC 2007


* Barry deFreese <bddebian-guest at alioth.debian.org> [2007-10-31 16:00:21 CET]:
> Added:
>    packages/trunk/xwelltris/debian/watch
> Log:
> svn add watch file.  I swore I already did this
> 
> 
> Added: packages/trunk/xwelltris/debian/watch
> ===================================================================
> --- packages/trunk/xwelltris/debian/watch	                        (rev 0)
> +++ packages/trunk/xwelltris/debian/watch	2007-10-31 15:00:21 UTC (rev 4509)
> @@ -0,0 +1,4 @@
> +version=3
> +
> +#http://xnc.jinr.ru/xwelltris/src/xwelltris-(.+)\.src\.tar\.gz
> +http://xnc.jinr.ru/xwelltris/downloads.html (?:.*/)xwelltris-(.*)\.src\.tar\.gz

 The match regex has two issues: It would be possible to match an empty
string, but that's just a style thing, but the non-clattering patch
match makes no sense at all - because it doesn't have any quanitfier
attatched. (?:...) defines the contained part as an atom for being able
to say I want to have that part matched that often. But if one doesn't
say how often it does it just once ... which makes the whole (?:...)
unneeded.

 So either there was a quantifier missing (like used in the uscan
manpage, a ?), or if it is missing on intention the usage of (?:...)
isn't needed at all.

 Please make up your mind what you want to actually match, and adjust
the regex accordingly.

 So long,
Rhonda



More information about the Pkg-games-devel mailing list