r4473 - packages/trunk/ketm/debian

[Eddy Petrișor]

Barry deFreese wrote:
> Author: bddebian-guest
> Date: 2007-10-26 21:02:18 +0000 (Fri, 26 Oct 2007)
> New Revision: 4473

> Modified: packages/trunk/ketm/debian/changelog
> ===================================================================
> --- packages/trunk/ketm/debian/changelog	2007-10-26 19:45:29 UTC (rev 4472)
> +++ packages/trunk/ketm/debian/changelog	2007-10-26 21:02:18 UTC (rev 4473)

> +  * Add desktop file and icon


> Added: packages/trunk/ketm/debian/ketm.desktop
> ===================================================================
> --- packages/trunk/ketm/debian/ketm.desktop	                        (rev 0)
> +++ packages/trunk/ketm/debian/ketm.desktop	2007-10-26 21:02:18 UTC (rev 4473)
> @@ -0,0 +1,10 @@
> +[Desktop Entry]
> +Version=1.0
> +Name=KETM
> +GenericName=ketm
> +Comment=Kill Everything That Moves
> +Exec=ketm
> +Icon=ketm
> +Terminal=false
> +Type=Application
> +Categories=Game;ArcadeGame;
> 

>  
> +	# Install desktop and icon files
> +	install -D -m 644 debian/ketm.desktop debian/ketm/usr/share/applications/ketm.desktop
> +	install -D -m 644 debian/ketm.xpm debian/ketm/usr/share/pixmaps/ketm.xpm
> +

Could you stop using install directly and use dh_install* instead? Pretty please!

Also it is considered good practice to register desktop files (via dh_desktop -
take care, it does not install the file, it just registers it)

-- 
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20071030/70518488/attachment.pgp