Bug#494700: warzone2100: Package build scripts continues even after build errors occurred

[Giel van Schijndel]

Package: warzone2100
Version: 2.1.0~2.svn5088-0
Severity: serious
Tags: patch
Justification: no longer builds from source

Due to the way how the build process is invoked using make the build
script (debian/rules) continues building even after a build error
occurred. Specifically the problem is that make is called "manually" on
all subdirectories without checking its return value. This happens in
the build-stamp and install rules.

Attached patch fixes this problem by explicitly terminating with a
non-zero return value (exit 1) as soon as a build error occurs.


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.25-2-amd64 (SMP w/1 CPU core)
Locale: LANG=nl_NL.UTF-8, LC_CTYPE=nl_NL.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages warzone2100 depends on:
ii  libc6                  2.7-13            GNU C Library: Shared libraries
ii  libgcc1                1:4.3.1-2         GCC support library
ii  libgl1-mesa-glx [libgl 7.0.3-5           A free implementation of the OpenG
ii  libglc0                0.7.1-2           QuesoGLC GLC implementation
ii  libglu1-mesa [libglu1] 7.0.3-5           The OpenGL utility library (GLU)
ii  libogg0                1.1.3-4           Ogg Bitstream Library
ii  libopenal0a            1:0.0.8-8         OpenAL is a portable library for 3
ii  libphysfs-1.0-0        1.0.0-5           filesystem abstraction library for
ii  libpng12-0             1.2.27-1          PNG library - runtime
ii  libpopt0               1.14-4            lib for parsing cmdline parameters
ii  libsdl-net1.2          1.2.7-2           network library for Simple DirectM
ii  libsdl1.2debian        1.2.13-2          Simple DirectMedia Layer
ii  libstdc++6             4.3.1-2           The GNU Standard C++ Library v3
ii  libvorbis0a            1.2.0.dfsg-3.1    The Vorbis General Audio Compressi
ii  libvorbisfile3         1.2.0.dfsg-3.1    The Vorbis General Audio Compressi
ii  libx11-6               2:1.1.4-2         X11 client-side library
ii  ttf-dejavu             2.25-1            Metapackage to pull in ttf-dejavu-
ii  warzone2100-data       2.1.0~2.svn5088-0 data files for warzone2100

warzone2100 recommends no packages.

warzone2100 suggests no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: warzone2100-exit-on-build-error.patch
Type: text/x-diff
Size: 660 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20080811/1731a2ab/attachment.patch