Bug#541971: xboard: displays kings for variant pieces

[h.g. muller]

This should be considered a short-coming of the documentation:

XBoard 4.4.0 has built-in bitmaps for all non-orthodox piece types only
in -boardSize middling and bulky, and almost all in petite. The Archbishop
and Chancellor have built-in bitmaps in any size from petite to bulky.
The other boardSizes can of course still be used with these variants
when people provide their own bitmaps / pixmaps. The reason we felt that
providing built-ins for only 3 sizes would be enough is that there really are
no standard representatons for un-orthodox pieces, so people are much
more likely to want to provide their own bitmaps. E.g. people playing
xiangqi are likely to prefer pieces that look like Chinese characters.
Providing built-ins for 2 x 22 piece types at 18 sizes would lead to
unjustifiable bloating of XBoard.

The XBoard manual fails to mention this, although it is mentioned in the
manual page of the engine playing these variants. This obviously should
be corrected.

It might be more user-friendly to actually put a conspicuous warning
message about this in the File -> New Variant dialog. That still leaves
people that start through the -variant command-line option in the cold.
But commands like

xboard -variant shogi -boardSize middling
xboard -variant xianggi -boardSize bulky

would not suffer from the reported limitation, and if this is conspicuously
stated in the manual in the place where these variants are mentioned,
that should provide people with enough warning.

I will see to it that this is done before the final release of 4.4.0.

H.G.Muller,
upstream XBoard developer