Bug#617265: wesnoth-1.9: New version 1.9.4 is out for a long time already. PLEASE update.

[Gerfried Fuchs]

        Hi!

* Vincent Cheng <vincentc1208 at gmail.com> [2011-04-01 03:52:54 CEST]:
> I've taken a closer look at this and I've tried to package the latest dev
> release of Wesnoth (1.9.5). I've been using my own PPA to test it [1], and
> it seems to build and run fine now. I've also attached a patch of my
> changes, if that helps any.

 Sorry, I don't see the need or requirement to switch to cdbs to make it
work properly again. If cdbs is able to make it work, so must debhelper
be able to do it. And actually, such changes definitely should be
documented in debian/changelog, that's actually what it's there for.

 Just a sidenote: Did you check where the files end up after your patch?
Do they appear in the same place as they were before? Including
translations?

> -	$(MAKE) -C build DESTDIR=$(CURDIR)/debian/tmp install
> +	$(MAKE) -C build DESTDIR=$(CURDIR) install

 Uh, *really* install into the current directory and not debian/tmp?
That looks pretty much like an error to me, at least it it's totally
counter-intuitive if it would end up in debian/tmp in the end?

> -	cd $(CURDIR)/debian/tmp/usr/share/games/wesnoth/$(BRANCH_VERSION)/data/tools \
> +	cd $(CURDIR)/usr/share/games/wesnoth/$(BRANCH_VERSION)/data/tools \
>  		&& chmod +x extractbindings unit_tree/TeamColorizer \
>  		wesnoth/wescamp.py wesnoth/wmldata.py wesnoth/wmlparser.py \
>  		wmlindent wmlflip wmllint wmlscope wesnoth_addon_manager \
> @@ -178,10 +177,10 @@
>  		done

 Sorry, this is totally weird, why did you go that approach?

>  	# move binaries to their proper name
> -	mv debian/wesnoth-$(BRANCH_VERSION)-core/usr/games/wesnoth \
> -		debian/wesnoth-$(BRANCH_VERSION)-core/usr/games/wesnoth-$(BRANCH_VERSION)
> -	mv debian/wesnoth-$(BRANCH_VERSION)-server/usr/games/wesnothd \
> -		debian/wesnoth-$(BRANCH_VERSION)-server/usr/games/wesnothd-$(BRANCH_VERSION)
> +	#mv debian/wesnoth-$(BRANCH_VERSION)-core/usr/games/wesnoth \
> +	#	debian/wesnoth-$(BRANCH_VERSION)-core/usr/games/wesnoth-$(BRANCH_VERSION)
> +	#mv debian/wesnoth-$(BRANCH_VERSION)-server/usr/games/wesnothd \
> +	#	debian/wesnoth-$(BRANCH_VERSION)-server/usr/games/wesnothd-$(BRANCH_VERSION)

 So it looks you are changing the install structure of the package?

 Your patch seems to completely rewriting the whole thing, actually I
don't really see the benefit or rationale for that, could you elaborate
why this is needed?

 Thanks,
Rhonda
-- 
Fühlst du dich mutlos, fass endlich Mut, los      |
Fühlst du dich hilflos, geh raus und hilf, los    | Wir sind Helden
Fühlst du dich machtlos, geh raus und mach, los   | 23.55: Alles auf Anfang
Fühlst du dich haltlos, such Halt und lass los    |