Patching the Mame source code

Emmanuel Kasper emmanuel at libera.cc
Thu Jun 16 17:41:40 UTC 2011


Hello Cesare !
I have seen you have add some patches to fix some Lintian warnings,
which is in principle a good thing.

 Some remarks though:
  * every patch should have a DEP-3 header, and should be notifyed to
the mame team in a bug report. We want to minimize the number of patches
we carry in the git repo for easy maintainance, and contribute back to
the mame team. Besides that, until now ALL of our bug reports have been
taken care.
see for instance: http://www.mametesters.org/view.php?id=4298
and
http://forums.bannister.org/ubbthreads.php?ubb=showflat&Number=69428#Post69428
Remember also that the mametesters.org team refuse to take account of
sdlmame /unix/linux problems ( they just complained about that today
against me :), the proper place is the sdlmame forum

 * I do care personnally about typos, and I notify them to mametesters,
where they get corrected see for instance
http://www.mametesters.org/view.php?id=4227
http://www.mametesters.org/view.php?id=4376
but  we don't carry patches correcting typos in the source code in a
debian package, it is not the place for such things. We have patches
correcting build problems, or functionnality problems.

I suggest next time you want to push something in the git repo to
propose it here before so we can discuss it.

I hope I am not being to bikeshedy :)

Manu



More information about the Pkg-games-devel mailing list