Bug#617783: src:supertuxkart: fails to build with enet 1.3.1

Peter Pentchev roam at ringlet.net
Fri Mar 11 13:32:50 UTC 2011


On Fri, Mar 11, 2011 at 12:51:26PM +0100, Ansgar Burchardt wrote:
> Source: supertuxkart
> Version: 0.7+dfsg1-1
> Severity: important
[snip]
> The attached patch allows to build supertuxkart with enet 1.3.1, but I did not
> do any further testing.

Wouldn't it be a slightly better idea (and maybe slightly more
acceptable upstream) to do this conditionally, e.g. with something like
the following (untested since right now I'm having some problems
building supertuxkart from source, some kind of complaints about a
missing src/enet/Makefile.in during the autoreconf run):

#if defined(ENET_VERSION_MINOR) && ENET_VERSION_MINOR >= 3
#define HAVE_ENET_1_3
#endif

...and then #ifdef the additional parameter to the functions?

G'luck,
Peter

-- 
Peter Pentchev	roam at ringlet.net roam at FreeBSD.org peter at packetscale.com
PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
If you think this sentence is confusing, then change one pig.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20110311/0515ff0e/attachment.pgp>


More information about the Pkg-games-devel mailing list