Bug#634350: kanatest: Implicit declaration of function 'gtk_combo_box_new_text'

[Colin Watson]

tags 634350 patch
user ubuntu-devel at lists.ubuntu.com
usertags 634350 ubuntu-patch oneiric
thanks

On Mon, Jul 18, 2011 at 07:03:01PM +0000, Andreas Moog wrote:
> Your package uses the function 'gtk_combo_box_new_text' but declares -DGTK_DISABLE_DEPRECATED
> This leads to the problem that some function prototypes aren't included and
> (which is bad) some integers are converted to pointers without a cast. See 
> on http://wiki.debian.org/ImplicitPointerConversions why this is a problem.

It's not a true fix, but I think you should drop
-DGTK_DISABLE_DEPRECATED for now, and that's enough to get things
building.  Patch follows.

The *_DISABLE_DEPRECATED macros are great tools for maintainers working
on ensuring that their code builds cleanly with current upstream
versions, and the deprecations will need to be fixed as part of porting
to GTK+ 3; but they are essentially a lint facility which has no place
being enabled by default in distributed code.

  * Drop -DGTK_DISABLE_DEPRECATED for now, since kanatest uses GTK+
    functions that are now deprecated (closes: #634350).

diff -u kanatest-0.4.8/debian/patches/series kanatest-0.4.8/debian/patches/series
--- kanatest-0.4.8/debian/patches/series
+++ kanatest-0.4.8/debian/patches/series
@@ -3,0 +4 @@
+004_enable_deprecated.patch
only in patch2:
unchanged:
--- kanatest-0.4.8.orig/debian/patches/004_enable_deprecated.patch
+++ kanatest-0.4.8/debian/patches/004_enable_deprecated.patch
@@ -0,0 +1,32 @@
+Description: Drop -DGDK_DISABLE_DEPRECATED for now
+Author: Colin Watson <cjwatson at ubuntu.com>
+Bug-Debian: http://bugs.debian.org/632604
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/770736
+Forwarded: no
+Last-Update: 2011-09-12
+
+Index: b/src/Makefile.am
+===================================================================
+--- a/src/Makefile.am
++++ b/src/Makefile.am
+@@ -1,6 +1,6 @@
+ REVISION := $(shell if test -e .svn; then echo -DREV=\"`LC_ALL=C svn info | sed -n '/^Rev/p'| sed -e 's/^Revision:\ //'`\"; fi;)
+ AM_CPPFLAGS = -Wall -DLOCALEDIR=\"$(datadir)/locale\" $(REVISION) \
+-			  -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED
++			  -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED
+ bin_PROGRAMS = kanatest
+ kanatest_SOURCES = about.c about.h \
+ 				   chart.c chart.h \
+Index: b/src/Makefile.in
+===================================================================
+--- a/src/Makefile.in
++++ b/src/Makefile.in
+@@ -149,7 +149,7 @@
+ var = @var@
+ REVISION := $(shell if test -e .svn; then echo -DREV=\"`LC_ALL=C svn info | sed -n '/^Rev/p'| sed -e 's/^Revision:\ //'`\"; fi;)
+ AM_CPPFLAGS = -Wall -DLOCALEDIR=\"$(datadir)/locale\" $(REVISION) \
+-			  -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED
++			  -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED
+ 
+ kanatest_SOURCES = about.c about.h \
+ 				   chart.c chart.h \

-- 
Colin Watson                                       [cjwatson at ubuntu.com]