Bug#643397: gnurobbo: FTBFS: konstruktor.c:248:5: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: gnurobbo
Version: 0.66+dfsg-1
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> cc  -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -pipe -Wall `sdl-config --cflags` -DPLATFORM_PC -DVERSION=\"0.66\" -DPACKAGE_DATA_DIR=\"/usr/share/games/gnurobbo\"   -DHAVE_DESIGNER -c konstruktor.c -o konstruktor.o
> konstruktor.c: In function 'konstruktor_init':
> konstruktor.c:248:5: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c: In function 'konstruktor_click':
> konstruktor.c:689:3: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:746:3: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:784:7: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:786:7: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:886:7: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:905:8: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1029:3: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1036:7: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1038:7: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1059:3: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1082:10: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1085:10: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1088:10: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1091:10: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1100:7: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1103:7: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1106:7: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1117:10: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1120:10: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1123:10: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1126:10: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1133:7: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1158:8: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1168:7: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1188:8: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1196:4: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1198:4: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1210:5: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1213:5: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c:1279:8: error: format not a string literal and no format arguments [-Werror=format-security]
> konstruktor.c: In function 'k_save_map':
> konstruktor.c:1781:7: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result [-Wunused-result]
> cc1: some warnings being treated as errors
> 
> make[1]: *** [konstruktor.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2011/09/23/gnurobbo_0.66+dfsg-1_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.