Fwd: Mame 0.145 and the sorry state of included libraries !
cesare.falco at gmail.com
Tue Feb 28 11:34:55 UTC 2012
Hey Manu and all!
> I have now a working patch to build with libjpeg, but I am not sure of
I've just improved it to allow switch between system/custom library.
This should make it acceptable upstream too, after Marcelo's has been rejected
Ehm... who's Marcelo anyway? I see his patch looks just the same as
that in the debian/patches tree :)
> the code quality. Maybe someone can review it ? Generally is there some
> kind of code review tools/people available inside Debian ?
Looks good to me but I have no idea regarding Debian coding...
> I mean it is better to fine embedded libs with system libs, but if it
> lowers the code quality ...
I agree, and also have to correct my former assumption that a 7zip
system library is available which is ...ehr... not!
> Note that with this patch Mame does not build anymore on Debian/Stable
> since it requires libjpeg8.
...or you can use the new BUILD_JPEGLIB switch to use the custom lib... ;)
More information about the Pkg-games-devel