Bug#677891: Should freeciv-client-gtk depend on gtk2-engines-pixbuf?

[Jacob Nevins]

Package: freeciv-client-gtk

Upstream here.

While investigating issues with theming, I noticed that the custom
"Freeciv" Gtk theme (used by default) uses 'engine "pixmap"' clauses.

Having dug into Gtk theming a bit, I think this implies that the theme
depends on the files in the gtk2-engines-pixbuf package in order to
display correctly.

However, I don't see that as a dependency in the Debian Freeciv package.
Should it be there?

I guess the symptoms of trying to use the theme without the engine
installed will be:

 - A warning on the console:
   Gtk-WARNING **: Unable to locate theme engine in module_path: "pixmap"

 - Presumably, failure to display some UI elements as intended.
   - However, I think this could be quite subtle. The yellow "paper"
     background does not appear to depend on the pixmap engine, so I
     guess the client will look themed at first glance.

But of course you wouldn't see this if you happened to have the engine
installed for some reason. I think historically, most installations will
have had it, but Ubuntu at least seem to have stopping shipping it as
part of their core system since 11.10 (it's now relegated to
"universe").

Also, it's possible that the dependency tree from freeciv-client-gtk
somehow pulls in gtk2-engines-pixbuf indirectly; I haven't checked
thoroughly.

However, if I'm right, I think there should be a direct dependency
(especially on Ubuntu).

Note: this is all theoretical so far. I haven't tested any of it, as I
don't have any suitable installations to hand. Perhaps I've
misunderstood something that means a dependency is not necessary to
declare.