RFS: visualboyadvance/1.8.0.dfsg-1 [RC]

Etienne Millon etienne.millon at gmail.com
Mon May 21 21:01:58 UTC 2012


* Vincent Legout <vincent at legout.info> [120521 22:44]:
> The package is fine and I could upload it as-is because it fix RC bugs
> but could you please fix these two points ?

Hello, thanks for reviewing this package !

> You use "find -delete" instead of "xargs rm -rf" but it doesn't work for
> the .deps directories because find fails if the directory is not
> empty. Thus debclean fails when the package has been built and the
> package cannot be built twice in a row.

Ah, I didn't see the -r in the third line. I fixed that.

> Can you please also mention that you update debhelper compatibility from
> 5 to 7 ? According to the git repository, you did that when switching to
> 3.0 (quilt) source format but I think it's worth mentioning in the
> changelog.

Fixed too. The "deb3" script added it, so I wrongly assumed that it
was implied by the new source format.

I pushed those fixes, rebuilt the package and uploaded it to mentors
again (the .dsc URL should be the same).

Merci !

-- 
Etienne Millon



More information about the Pkg-games-devel mailing list