Bug#688712: wesnoth: needs to handle symlink to directory change of /usr/share/doc/wesnoth

Vincent Cheng vincentc1208 at gmail.com
Sat Nov 17 07:19:57 UTC 2012


On Fri, Nov 2, 2012 at 1:37 PM, Vincent Cheng <vincentc1208 at gmail.com> wrote:
> tag 688712 + patch
> thanks
>
> Hi Rhonda,
>
> On Mon, Sep 24, 2012 at 4:07 PM, Andreas Beckmann <debian at abeckmann.de> wrote:
>> Package: wesnoth
>> Version: 1:1.10.3-2
>> Severity: important
>> User: debian-qa at lists.debian.org
>> Usertags: piuparts
>>
>> Hi,
>>
>> during a test with piuparts I noticed your package partially overwrites
>> wesnoth-1.8-data in squeeze to wheezy upgrades.
>>
>> /usr/share/doc/wesnoth is a link to wesnoth-1.8-data in squeeze and a
>> regular directory in wheezy. dpkg does not replace symlinks with
>> directories and vice versa, therefore maintainer scripts need to be
>> used.
>
> Since both wesnoth-1.10 and wesnoth-1.10-core are symlinks to
> /usr/share/doc/wesnoth-1.10-data, I'm assuming that your intention was
> for /usr/share/doc/wesnoth to be a symlink to
> /usr/share/doc/wesnoth-1.10-data as well, right? Assuming that this is
> correct, I propose the following patch (which I've also committed into
> the git repo). It creates the symlink in the rules file, and includes
> a postinst script for the wesnoth package to overwrite the
> /usr/share/doc/wesnoth directory as a symlink for users who already
> have the current wesnoth package in wheezy installed (heavily based on
> libpipeline's postinst script).
>
> (I admit I haven't tested this yet, but I'll do so ASAP.)

Just to follow up on my previous message, I've attached a new debdiff
that doesn't make the package FTBFS at least. pbuilder and piuparts
logs are also attached, although my changes actually generate new
debsum errors when upgrading from wheezy to these proposed packages:

24m39.7s ERROR: FAIL: debsums reports modifications inside the chroot:
  debsums: missing file
/usr/share/doc/wesnoth-1.10-data/NEWS.Debian.gz (from
wesnoth-1.10-data package)
  debsums: missing file
/usr/share/doc/wesnoth-1.10-data/changelog.Debian.gz (from
wesnoth-1.10-data package)
  debsums: missing file /usr/share/doc/wesnoth-1.10-data/changelog.gz
(from wesnoth-1.10-data package)
  debsums: missing file /usr/share/doc/wesnoth-1.10-data/copyright
(from wesnoth-1.10-data package)

However, those files do seem to be present inside the
wesnoth-1.10-data .deb, so I'm not sure why piuparts is throwing out
these errors. As for the original errors:

  debsums: no md5sums for wesnoth-1.8
  /usr/share/doc/wesnoth-1.8-data/changelog.Debian.gz
  /usr/share/doc/wesnoth-1.8-data/changelog.gz
  /usr/share/doc/wesnoth-1.8-data/copyright

I don't see how this can be fixed in wheezy, since wesnoth-1.8-data is
no longer available in wheezy.

I'm going to take a look at this again when I have time, but since
this is a RC bug I'd definitely appreciate help...

Regards,
Vincent
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wesnoth-1.10_1.10.3-3.debdiff
Type: application/octet-stream
Size: 1737 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20121116/3f659e26/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wesnoth-1.10_1.10.3-3_amd64.build
Type: application/octet-stream
Size: 3371461 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20121116/3f659e26/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wesnoth-1.10_1.10.3-3_piuparts.log
Type: application/octet-stream
Size: 266125 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20121116/3f659e26/attachment-0005.obj>


More information about the Pkg-games-devel mailing list