Bug#700222: freeciv-server: irrigation of swamps broken

[Jacob Nevins]

David Christensen writes:
> Irrigations of swamps is broken.  Please review workers near Aarhus on
> turn 132 and turn 163.

Can you provide a bit more information on what exactly is not behaving
as you expect?

In T0132 we have at [l tgt="tile" x=66 y=40 /]:
  [l tgt="unit" id=806 name="Archers" /], fortified
  [l tgt="unit" id=805 name="Workers" /], manually irrigating, 14 turns to go

In T0163 at the same tile we have the same Archers and Workers units
doing the same things, with the Workers having 2 turns to go.

There's no evidence of global warming or similar disturbing factors.

I'm going to guess that you say that the Workers have been undisturbed
in the intervening time, and that you'd thus have expected them to have
finished converting the swamp to grassland around T0146.

2.2.1 is rather old, but I don't recall any progress-losing bugs fixed
since then, offhand. There is a hazard though: if you were to stop the
Workers from working, even for a moment, then you do lose all progress;
and it was rather easy to do this if you had "Clear unit orders on
selection" enabled in the options -- just selecting the unit would lose
everything.
(This behaviour was improved in 2.3.0 -- from that version, if you
immediately set the unit to irrigating again, it will pick up where it
left off. <http://gna.org/bugs/?15510>)

Is it possible that this is what happened?

Otherwise, without some more information about what happened in the
interim, it's going to be hard to diagnose this. Do you have more
savefiles?