Bug#726209: ballz: missing icon entry in menu file Jessie Release Goal

[Markus Koschany]

tags 726209 patch
thanks

Hi Sylvain,

I'm attaching a patch that addresses the missing menu icon.

Your menu file is simply missing an icon field/entry and should look
like this one:

?package(ballz):needs="X11" \
  section="Games/Action" \
  title="B.A.L.L.Z." \
  icon="/usr/share/pixmaps/ballz.xpm" \
  command="/usr/games/ballz"

You can easily convert ballz.png into a xpm file at build time with
imagemagick and install this file to /usr/share/pixmaps.

Everyone who runs a pure window manager setup with the Debian menu
package will benefit from it, provided the window manager displays menu
icons. Most of them do.

Thanks for considering the patch.

Regards,

Markus
-------------- next part --------------
diff -Nru ballz-1.0.2/debian/ballz.install ballz-1.0.2/debian/ballz.install
--- ballz-1.0.2/debian/ballz.install	2010-05-23 13:49:44.000000000 +0200
+++ ballz-1.0.2/debian/ballz.install	2013-10-13 20:41:25.000000000 +0200
@@ -1,3 +1,4 @@
 usr/games/ballz
 usr/share/applications/
 usr/share/pixmaps/
+ballz.xpm usr/share/pixmaps
diff -Nru ballz-1.0.2/debian/changelog ballz-1.0.2/debian/changelog
--- ballz-1.0.2/debian/changelog	2011-06-05 22:47:17.000000000 +0200
+++ ballz-1.0.2/debian/changelog	2013-10-13 20:41:25.000000000 +0200
@@ -1,3 +1,13 @@
+ballz (1.0.2-2) unstable; urgency=low
+
+  * Bump compat level to 9 and require debhelper >= 9.
+  * Use canonical VCS-URI.
+  * Bump Standards-Version to 3.9.4, no changes.
+  * Add missing icon to menu file and create ballz.xpm with imagemagick at
+    build time. (Closes: #726209)
+
+ -- Markus Koschany <apo at gambaru.de>  Sun, 13 Oct 2013 20:38:37 +0200
+
 ballz (1.0.2-1) unstable; urgency=low
 
   [ Sylvain Beucler ]
diff -Nru ballz-1.0.2/debian/clean ballz-1.0.2/debian/clean
--- ballz-1.0.2/debian/clean	1970-01-01 01:00:00.000000000 +0100
+++ ballz-1.0.2/debian/clean	2013-10-13 20:41:25.000000000 +0200
@@ -0,0 +1 @@
+ballz.xpm
diff -Nru ballz-1.0.2/debian/compat ballz-1.0.2/debian/compat
--- ballz-1.0.2/debian/compat	2011-05-23 22:43:49.000000000 +0200
+++ ballz-1.0.2/debian/compat	2013-10-13 20:41:25.000000000 +0200
@@ -1 +1 @@
-8
+9
diff -Nru ballz-1.0.2/debian/control ballz-1.0.2/debian/control
--- ballz-1.0.2/debian/control	2011-05-23 22:43:49.000000000 +0200
+++ ballz-1.0.2/debian/control	2013-10-13 20:41:25.000000000 +0200
@@ -3,11 +3,12 @@
 Priority: optional
 Maintainer: Debian Games Team <pkg-games-devel at lists.alioth.debian.org>
 Uploaders: Sylvain Beucler <beuc at debian.org>
-Build-Depends: debhelper (>= 8), autotools-dev (>= 20100122.1), libguichan-dev, libdumb1-dev, libaldmb1-dev
-Standards-Version: 3.9.2
+Build-Depends: debhelper (>= 9), autotools-dev (>= 20100122.1), libguichan-dev, libdumb1-dev, libaldmb1-dev
+Build-Depends-Indep: imagemagick
+Standards-Version: 3.9.4
 Homepage: http://www.allegro.cc/forums/thread/590831
-Vcs-Git: git://git.debian.org/git/pkg-games/ballz.git
-Vcs-Browser: http://git.debian.org/?p=pkg-games/ballz.git
+Vcs-Git: git://anonscm.debian.org/pkg-games/ballz.git
+Vcs-Browser: http://anonscm.debian.org/gitweb/?p=pkg-games/ballz.git
 
 Package: ballz
 Architecture: any
diff -Nru ballz-1.0.2/debian/menu ballz-1.0.2/debian/menu
--- ballz-1.0.2/debian/menu	2010-05-23 13:49:44.000000000 +0200
+++ ballz-1.0.2/debian/menu	2013-10-13 20:41:25.000000000 +0200
@@ -1,2 +1,6 @@
-?package(ballz):needs="X11" section="Games/Action"\
-  title="B.A.L.L.Z." command="/usr/games/ballz"
+?package(ballz):needs="X11" \
+  section="Games/Action" \
+  title="B.A.L.L.Z." \
+  longtitle="B.A.L.L.Z. platform/puzzle game where you control a rolling ball" \
+  icon="/usr/share/pixmaps/ballz.xpm" \
+  command="/usr/games/ballz"
diff -Nru ballz-1.0.2/debian/rules ballz-1.0.2/debian/rules
--- ballz-1.0.2/debian/rules	2011-05-23 22:43:49.000000000 +0200
+++ ballz-1.0.2/debian/rules	2013-10-13 20:41:25.000000000 +0200
@@ -22,6 +22,9 @@
 override_dh_auto_configure:
 	dh_auto_configure -- --bindir=/usr/games --datadir=/usr/share/games --mandir=/usr/share/man
 
+override_dh_auto_build-indep:
+	convert -monitor -resize 32x32 $(CURDIR)/desktop/ballz.png $(CURDIR)/ballz.xpm
+
 override_dh_strip:
 	# Create -dbg package with debug symbols for gdb
 	dh_strip --dbg-package=ballz-dbg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 966 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20131013/6286866e/attachment.sig>