Bug#807710: scummvm: please build with libSDL2 on RaspBian

[Alexandre Detiste]

Package: scummvm
Version: 1.8.0
Severity: wishlist
Tags: patch

Hi,

I'm filling this in advance for v1.8.0.

When running on Raspberry, scummvm should prefer SDL2 over SDL1
because it really works better. On other platform (including
other 'armhf' platforms ?), SDLv1 will remain prefered for now.

I settled on this patch after reading this Raphaël Hertzog's blog and all
comments:

https://raphaelhertzog.com/2010/09/27/different-dependencies-between-debian-
and-ubuntu-but-common-source-package/

It gives good results on non-armhf & on RaspBian.

For the official DebianArmhf port; we can't know in advance
if the binaries will be used on a RaspberryPi or some
other Armhf device ("2016 will be the year of the ARM laptop"
said some famous scuba diver...).

Maybe it's better to always use SDL 2 on armhf devices, I don't know;
then d/control would need "Build-Depend: libsdl1.2-dev [!armhf], libsdl2-dev
[armhf]"
and the dpkg-vendor trick could be dropped.




diff -u -r scummvm-debian/debian/control scummvm/debian/control
--- scummvm-debian/debian/control       2015-12-11 22:03:22.935786582 +0100
+++ scummvm/debian/control      2015-12-11 22:19:04.588012194 +0100
@@ -15,6 +15,7 @@
               ,libmad0-dev
               ,libmpeg2-4-dev
               ,libsdl1.2-dev
+              ,libsdl2-dev [armhf]
               ,libtheora-dev
               ,libvorbis-dev
               ,libz-dev
diff -u -r scummvm-debian/debian/rules scummvm/debian/rules
--- scummvm-debian/debian/rules 2015-12-11 22:03:22.935786582 +0100
+++ scummvm/debian/rules        2015-12-11 22:09:11.759026908 +0100
@@ -16,6 +16,7 @@
 override_dh_auto_clean:
        ##718164 "FTBFS: Makefile:87: *** You need to run ./configure before
you can run make".
        [ -f config.mk ] || touch config.mk
+       dpkg-vendor --is Raspbian && sed -i 's/libsdl1.2-dev/libsdl2-dev/'
debian/control || true
        dh_auto_clean

 override_dh_auto_configure:



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing'), (450, 'unstable'), (400, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-1-amd64 (SMP w/6 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)