Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG

[Simon McVittie]

On 09/02/15 11:43, Alexandre Detiste wrote:
> Le lundi 9 février 2015, 11:25:11 Simon McVittie a écrit :
>> I would rather have new games consistently install their data to the
>> default location (/usr/share/games/PACKAGENAME)
> 
> I agree, but this "-data" in package name sounds completely extraneous,
> why not use "/usr/share/games/PACKAGENAME".rstrip('-data') instead as default ?

rstrip doesn't work like you think it does, but I get the general idea.

I used PACKAGENAME instead of (PACKAGENAME with any trailing -data
removed) because when you're making an essentially arbitrary design
choice, I think there's value in choosing the option that is easiest to
document. However, I do see your point, and removing -data by default
would also be OK (but please do not break existing games).

game-data-packager-produced packages are a bit special, because they are
non-distributable and difficult to update. As a result, I would like to
encourage this rule of thumb: g-d-p-produced packages are a container
for proprietary data files that we cannot legally ship, and nothing
more; all cleverness, and in particular anything that could possibly
have a bug, should happen somewhere else. If we can eventually end up
with "most" -data packages literally only having
/usr/share/games/PACKAGE and /usr/share/doc/PACKAGE, that illustrates
that rule rather well.

Adding .desktop files and icons for Doom WADs and ScummVM/ResidualVM
games does stretch that rule, because .desktop files can have bugs (e.g.
lack of Keywords, or a low-quality icon). I would be tempted to put the
.desktop files in ScummVM and ResidualVM, with a TryExec pointing to a
dummy executable in the relevant -data package, although for ScummVM
that does get into difficult issues of "should these be in contrib?" and
I don't think we necessarily want a contrib equivalent of src:quake just
for the .desktop files.

> (and quake3-data is a link-farmed from quake3 anyway) 

As described on
https://github.com/a-detiste/game-data-packager/commit/e432de5f39822f01bae078e454fbfb43341ea72d
there is a reason why I did it like this: quake3-data now ships the Team
Arena part of the patch as well as the baseq3 part (because otherwise,
gdp would potentially have to download the patch twice, once for the Q3
parts and once for the TA parts) but it is a bad idea to put
missionpack/*.pk3 in the engine's search path if we don't have the
complete set.

>> In this case I think I would have both D3 and D3:ROE install to
>> usr/share/games/doom3-data, and have D3:BFG install to
>> usr/share/games/doom3-bfg-data.

Without -data would be fine too.

    S