Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG

[Simon McVittie]

On 10/02/15 10:10, Alexandre Detiste wrote:
>>> Again, I'd have used doom3-bfg-data here.
> I think it's better to have two distinct doom3-{*-}data and
> doom3bfg-{*-}data namespaces,
> so we immediately see if an expansion is for the original game or the
> BFG edition.

Sure, that's reasonable.

>>> Thanks for the files, I only needed to remove the references to doom.wad, doom2.wad
>>> and nerve.wad; these are already handled by other yaml files.
>>
>> note sure what's the effect... but the bfg edition includes those games
>> as well, so they also need to be installed.
> 
> The current yaml layout only accept 1 steam id+path to look into for files;
> so someone would have now to do:
>    game-data-packager doom3
>    game-data-packager doom2 <full path of Doom 3 BFG>
>    game-data-packager doom <full path of Doom 3 BFG>
> to package everything, not much fun.

There are two parallel issues here:

* Doom 3 BFG contains WADs which can be used with any Doom
  source port such as chocolate-doom

* Doom 3 BFG itself contains a modernized Doom source port by id
  Software, "Doom Classic", with which to play those WADs

So I think what Tobias is saying is that we should include doom.wad,
doom2.wad, nerve.wad in doom3bfg-data so you can play them in "Doom
Classic", regardless of whether we also pick them up for doom-wad and
doom2-wad so you can play them in chocolate-doom or whatever.

Their size is tiny compared with Doom 3, so I don't think the
duplication would be a real problem.

We could make doom and doom2 search /usr/share/games/doom3bfg in
addition to any other paths, to make this easier?

We could perhaps even have a mechanism for doom3bfg to say

    includes_games:
    - doom
    - doom2

which would try to load those YAML files and build their packages too?

> I guess adding "steam2:" would be too hackish for the yaml...
> So we need to move everything to a new layout like this, ok ?
> (I can make the populate...() accept both syntax too):
> 
> packages:
>   doom2-wad:
>      steam:
>         2300: common/Doom 2
>         208200: common/DOOM 3 BFG Edition

How confident are you that there will never be Steam metadata other than
id and path?

I think I'd prefer a list of dicts like this:

steam:
- { id: 2300, path: "common/Doom 2" }
- { id: 208200, path: "common/Doom 3 BFG Edition" }

Regards,
    S