Bug#780724: Bug#780725: PATH used for building is not specified

[Holger Levsen]

clone 780724 -1
reassign -1 pbuilder
severity -1 serious
retitle -1 pbuilder must defines PATH as in debian-policy (and as on buildds)
# justification: breaks package builds, see 780724

Hi Bill, hi pbuilder maintainers,

(leaving full quote to give context to the pbuilder maintainers)

On Mittwoch, 18. März 2015, Bill Allombert wrote:
> On Wed, Mar 18, 2015 at 12:48:13PM +0100, Holger Levsen wrote:
> > package: debian-policy
> > affects: simutrans-pak128.britain
> > x-debbugs-cc: ansgar at debian.org,
> > reproducible-builds at lists.alioth.debian.org
> > 
> > Hi,
> > 
> > I've just noticed and filed "#780724: simutrans-pak128.britain ftbfs if
> > PATH does not contain /usr/games" which made me notice that PATH is not
> > specified in debian-policy.
> > 
> > buildd.debian.org uses
> > 
> > PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/ga
> > mes
> > 
> > while pbuilder uses
> > 
> > PATH="/usr/sbin:/usr/bin:/sbin:/bin"
> > 
> > So this brings up three questions: a.) should /usr/games be in PATH when
> > building packages? b.) should /usr/local/* be part of PATH? and finally,
> > c.) what should PATH be, what must PATH include, what must not be
> > included in PATH?
> 
> I think this already come up, but I cannot find it.
> This raise the question, though: why binaries needed to build packages are
> in /usr/games in the first place ?
> 
> In the simutrans instance, the culprit is the file /usr/games/makeobj which
> is not a game and has a very generic name, Also kdesdk-scripts provides
> /usr/bin/makeobj, so there is a filename conflict already.

yes, that's why I left 780724 assigned to simutrans-pak128.britain...

> Maybe it would be better to move it to /usr/lib/simutrans/
> and use an absolute path.

probably, yeah.

> In any case, policy currently has:
> 
> 10.10. File names
> -----------------
> 
>      The name of the files installed by binary packages in the system PATH
>      (namely `/bin', `/sbin', `/usr/bin', `/usr/sbin' and `/usr/games')
>      must be encoded in ASCII.
> 
> though it is a strange place to define the system path.

Thanks. Thus I'ved cloned 780724 and assigned the clone to pbuilder, so that 
pbuilder gets fixed.

Feel free to close 780725 or keep it open to move the PATH definition to a 
better place.


cheers,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20150318/5291f079/attachment.sig>