Bug#804804: "game-data-packager gog", atlantis & baldurs-gate-2 are broken

[Alexandre Detiste]

Package: game-data-packager
Version: 43
Severity: normal

This was unexpectedly caused by:

1) "Reduce duplication by making GOG path search behave more like Steam"
   http://anonscm.debian.org/cgit/pkg-games/game-data-
packager.git/commit/?id=f5e18bdea146fc250a8993a8c43a5d5f24039ba4

   This change was obviously needed.

2) The fact that I should have made gog_download_name() more robust
   in the first time

I should have tested this properly before release.

I'll commit the fix when the BTS will have generated a bug number
to fill in the changelog.


baldurs-gate-2 baldurs-gate-2-en-data
atlantis fate-of-atlantis-de-data
atlantis fate-of-atlantis-es-data

--- a/game_data_packager/__init__.py
+++ b/game_data_packager/__init__.py
@@ -1223,13 +1223,13 @@ class GameData(object):
     def gog_download_name(self, package):
         if package.gog == False:
             return
         gog = package.gog or self.gog
         if not gog:
             return
-        return gog.get('game', gog['url'])
+        return gog.get('game', gog.get('url'))

$ game-data-packager gog
INFO:game-data-packager.gog:Visit game-data-packager @ GOG.com:
https://www.gog.com/mix/games_supported_by_debians_gamedatapackager
INFO:game-data-packager.gog:Found 94 game(s) !
Traceback (most recent call last):
  File "/usr/lib/python3.4/runpy.py", line 170, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.4/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/share/games/game-data-packager/game_data_packager/__main__.py",
line 21, in <module>
    run_command_line()
  File "/usr/share/games/game-data-packager/game_data_packager/__init__.py",
line 1203, in run_command_line
    run_gog_meta_mode(parsed, games)
  File "/usr/share/games/game-data-packager/game_data_packager/gog.py", line
139, in run_gog_meta_mode
    id = data.gog_download_name(package)
  File "/usr/share/games/game-data-packager/game_data_packager/__init__.py",
line 959, in gog_download_name
    return gog.get('game', gog['url'])
KeyError: 'url'



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing'), (450, 'unstable'), (400, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-1-amd64 (SMP w/6 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)