Bug#776540: game-data-packager: please add support for games working with gemrbd engine

[Alexandre Detiste]

Le samedi 10 octobre 2015, 17:16:51 Markus Koschany a écrit :
> Control: tags -1 patch pending
> 
> Hi,
> 
> ok I give up for now because I can't get it to work with more than one
> language version. I have pushed baldurs-gate-1.yaml to git master which
> supports the English Linux installer from gog.com.

Thanks

I commited these tow more thins:

- I liked the shorter packager names in the test branch better
("baldurs-gate-1-data" or "baldurs-gate1-data");
I picked that up from there; the 'marketing name' remain
in the package short description.

- I don't yet know if gemreb is case-sensitive;
but for the documentation in /usr/share/doc/ that should
never matter. If these files were needed at runtime they would
need to go in /usr/share/games anyway.

> The debug information from g-d-p are very sparse. I only see

with "DEBUG=1 ./run ...." you'll get pages & pages of log,
maybe some of this was needed when building the core
functionality and could be disabled now.

> That's it and then it fails. The --verbose flag doesn't add any extra
> information.

The --verbose flag show output from the external tools.

Showing the missing files when --package is explicitely defined
would be a plus !

> Please correct me if I am wrong: At first I used
> 
> game-data-packager make-template setup_baldurs_gate_2.0.0.20.exe
> setup_baldurs_gate_german_2.0.0.20.exe > bg_en_de.txt
> 
> this produces output like chitin.key?en. How can I use g-d-p with the
> --collisions=rename option of innoextract?

That's not yet implemented & this is the exactly only
game that would need this and can't be packaged with innoextract 1.4-1
& I'll have to recheck all the other archives with this --collisions=rename flag.

> When I manually unpack both windows installers with innoextract
> --collisions=rename and then run make-template on both unpacked
> directories, I get something which looks similar to your last e-mail
> attachment but it is still not the same. I've pushed my bg_en_de.txt
> file to the baldurs-gate branch, in case you want to have look at it.

Thanks

> This whole renaming is somehow crazy. What do you think about the
> following design: just declare all files with size and hashsums per
> package and enforce that the user passes a language option to
> game-data-packager like
> 
> game-data-packager baldurs-gate-1 --lang de <path-to-game-data>
> I would only have to trim the raw output from make-template, remove some
> files and that's it. No renaming necessary. There will be duplicate
> information regarding file names, sizes and hashsums but this design is
> much less error prone and simpler to maintain, IMO.

I think it should be easier & less error-prove to package Baldur's Gate the
current way than changing everything else; make-template is already quite improved.


Greets,

Alexandre

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20151010/30197fad/attachment.sig>