Bug#801671: support Quake3 GOG package

[Alexandre Detiste]

2015-10-18 19:15 GMT+02:00 Simon McVittie <smcv at debian.org>:
> On 18/10/15 14:48, vv221 wrote:
>> You can find the result of a debug run in the attached .log.gz file.
>
> Thanks. It looks as though there may be two bugs here:
>
> * a bug in the metadata: we ask innoextract to extract files from
>   setup_quake3_2.0.0.2.exe, but then we do not actually find all the
>   files that our metadata says it should provide, possibly because the
>   names seen in the archive (extras/help/manual/htmlpages/*) are not a
>   case-insensitive match for the names we ask innoextract to unpack
>   (Help/Manual/htmlpages/*);

Hi,

This commit, while fixing something else, likely broke it:

http://anonscm.debian.org/cgit/pkg-games/game-data-packager.git/commit/data/quake3.yaml?id=13c256631f3c0e6ceb74a5f98afc617b54785d28

Now I feel this extra check "if 'unpack' not in provider.unpack:"
before doing the automatic version
suffix striping  "i = i.split('?')[0]" doesn't make sense as we'll
likely never meet a file
with a '?' in his name in a innoextract archive.

http://anonscm.debian.org/cgit/pkg-games/game-data-packager.git/tree/game_data_packager/build.py#n1123

> * a bug in the g-d-p code: after that has happened, the g-d-p code does
>   not recover gracefully, but instead tries to extract the same files
>   from the same archive in order to provide some other file that might
>   not actually be found. We should extract each archive at most once.

I've seen some useless looping before, but it only show up if there's
some other bug.
Downloading the same file in loop from GOG is not a nice behaviour,
so there's the 'lgogdownloaded' set to guard against that;

something similar is needed in fill_gap().

Alexandre