Bug#801671: support Quake3 GOG package

[Alexandre Detiste]

Le lundi 19 octobre 2015, 17:58:52 vv221 a écrit :
> No more multiple calls to innoextract since commit
> d6d0d7451020be2fb632fc86ea82b3b207f8b9b6 (quake3: fix
> Help/DedicatedServer.html alternative)
> The build now goes fine from beginning to end with the GOG installer.

Thanks for testing.

Even the HTML pages are mostly ok.

$ apt-get install linkchecker
$ linkchecker /usr/share/doc/quake3-data/Help/Index.html
564 links in 195 URLs checked. 0 warnings found. 4 errors found
  /usr/share/doc/quake3-data/Help/Support/CustomerSupport/Customer_Support.htm
  /usr/share/doc/quake3-data/Help/Support/Information/Minimum_System_Requirements.htm
  /usr/share/doc/quake3-data/Help/Support/Information/Improving_Performance.htm
  /usr/share/doc/quake3-data/Help/Licenses.txt

CustomerSupport.htm links to ~100 tiny files with mail adress of mostly defunct companies,
Minimum_System_Requirements.htm is lower than current Debian's minimum requirement.

The 4 files were all direclty linked from Index.html; maybe writing an alternate one
that links to more current information would be the way to go ;-)


---

Innoextract support should be "good enough" for normal users, now I feel it could still
be further optimized & not unpack archive we later decide we don't need...
(but in real life, users just wouldn't have downloaded all those dubs in the first time)

Maybe an extra 'UNPACKING_NEEDED' status and do the unpacking
just-in-time in the second step like the downloads are handled.

Also making the "%s should have provided %s but did not" error
more generic and not limited to .zip archive and tarballs.



        if should_provide:
            for missing in sorted(should_provide):
                logger.error('%s should have provided %s but did not',
                        name, missing)

class FillResult(Enum):
    UNDETERMINED = 0
    IMPOSSIBLE = 1
    DOWNLOAD_NEEDED = 2
    COMPLETE = 3
    UPGRADE_NEEDED = 4

./run simon1 -d /tmp --no-compress --no-search ../../gdp/simon
INFO:game-data-packager.build:identifying ../../gdp/simon/setup_simon_the_sorcerer_french_2.1.0.21.exe
INFO:game-data-packager.build:identifying ../../gdp/simon/setup_simon_the_sorcerer_german_2.0.0.18.exe
INFO:game-data-packager.build:identifying ../../gdp/simon/setup_simon_the_sorcerer_spanish_2.0.0.18.exe
INFO:game-data-packager.build:identifying ../../gdp/simon/setup_simon_the_sorcerer_italian_2.0.0.18.exe
INFO:game-data-packager.build:identifying ../../gdp/simon/setup_simon_the_sorcerer_2.0.0.18.exe
INFO:game-data-packager.build:identifying /tmp/gdptmp.cuyio0dr/tmp/setup_simon_the_sorcerer_2.0.0.18.exe.d/app/SIMON.WAV
INFO:game-data-packager.build:identifying /tmp/gdptmp.cuyio0dr/tmp/setup_simon_the_sorcerer_italian_2.0.0.18.exe.d/app/SIMON.VOC
INFO:game-data-packager.build:identifying /tmp/gdptmp.cuyio0dr/tmp/setup_simon_the_sorcerer_spanish_2.0.0.18.exe.d/app/SIMON.VOC
INFO:game-data-packager.build:simon-the-sorcerer1-dos-fr-data can be downloaded with lgogdownloader
INFO:game-data-packager.build:identifying /tmp/gdptmp.cuyio0dr/tmp/setup_simon_the_sorcerer_german_2.0.0.18.exe.d/app/SIMON.mp3
INFO:game-data-packager.build:identifying /tmp/gdptmp.cuyio0dr/tmp/setup_simon_the_sorcerer_french_2.1.0.21.exe.d/app/SIMON.VOC
INFO:game-data-packager.build:will not produce "simon-the-sorcerer1-dos-en-data" because better version "simon-the-sorcerer1-en-data" is also available
INFO:game-data-packager.build:will not produce "simon-the-sorcerer1-dos-fr-data" because better version "simon-the-sorcerer1-fr-data" is also available
INFO:game-data-packager.build:will not produce "simon-the-sorcerer1-dos-de-data" because better version "simon-the-sorcerer1-de-data" is also available
INFO:game-data-packager.build:will not produce "simon-the-sorcerer1-de-data" because "de" is not in LANGUAGE selection
INFO:game-data-packager.build:will not produce "simon-the-sorcerer1-it-data" because "it" is not in LANGUAGE selection
INFO:game-data-packager.build:will not produce "simon-the-sorcerer1-es-data" because "es" is not in LANGUAGE selection
INFO:game-data-packager.build:will not produce "simon-the-sorcerer1-en-data" because "fr" is prefered language
INFO:game-data-packager.build:generating package simon-the-sorcerer1-fr-data
generated "/tmp/simon-the-sorcerer1-fr-data_43_all.deb"