Bug#776540: game-data-packager: please add support for games working with gemrbd engine

[Markus Koschany]

Am 29.09.2015 um 13:05 schrieb Alexandre Detiste:
> 2015-09-29 11:21 GMT+02:00 Markus Koschany <apo at gambaru.de>:
[...]
> I own these from GOG too. When the packaging of the GOG version is
> done it should be tested against the original physical media too;
> to avoid surprises; like GOG version of Zork Inquisitor shipping the
> obsolete Z-Engine and some bits of it's assets slipping in package definition;
> or GOG skipping some *.bak from the retail CD of Theme Hospital...

Absolutely agreed. This should be tested against "real" physical media
releases of the games. I intend to provide patches for the gog.com
versions first. Let's see if there is demand and feedback for more.

[...]

>> Unfortunately g-d-p hardcodes the platform-priority for lgogdownloader
>> to linux,windows.
> 
> I don't understand why you feel this is unfortunate, maybe you mistook
> this parameter with " --platform" which does something else.

Providing a sane default is fine. I only find it unfortunate that I
can't override the values in my yaml file.

I would like to add

platform: windows
language: de

to the specific yaml file. But this is apparently not implemented yet.
(Just a finding, nothing serious :) )

[...]
> An other reason for not having the platform: tag in the yaml
> file is that GOG.com may decide to release more & more
> linux packages after each GDP release,
> so this checked at runtime.

Ok. I appreciate that we prioritize linux versions. But there is no
runtime option to override the lgogdownloader behaviour, isn't it?
I can't use
game-data-packager baldurs-gate-1 --platform windows --language de

or something like that?

[...]
>> Is there another way to
>> force the download of the English windows installer
> 
> G-D-P will read the contents of $LANGUAGE
> and the $LANG to pickup the best match;
> and then call "lgogdownloader --language XX"
> 
> The only way to override this for now is this way:
>    LANGUAGE=en game-data-packager kyrandia

I see. I would prefer if this could be adjusted with yaml parameters.


> Now for the rest:
> 
> - G-D-P has not yet support for multipart GOG archives used for huge games,
>   multipart archive are a lot of pain (see ARJ, unshield handling) by
> themselves;
>   I will add this soon.
> 
>   To avoid to download the same game again & again & again for tests I wrote
>   a fake lgogdownloader, that can be symlinked in ~/bin .

Thanks. I usually download the provided archive once and then I run

game-data-packager <game> <archive>

and then I hope g-d-p will do the right thing. :)

Although I have 120 MBit to my disposal, I think this is more sane. :P

>   http://anonscm.debian.org/cgit/pkg-games/game-data-packager.git/tree/tools/fake_lgog.py
> 
>   I need to add multipart archive support here too & replace "cp"  by
> a "ln" to avoid to fill up /tmp.

I experienced the same issue. I use export TMP=path-to-more-free-space

[...]
> Having at first a yaml with only baldurs-gate1-en-data is OK ! ;
> other languages can be added "later"; and there is the "missing_langs: []"
> tag to make it show up on the dashboard.

I agree. My goal is to provide a working English version first.


> 
> PS: nice idea to work on a branch for this.

Yeah, I feel more comfortable with this solution. I only push to master
when I am sure that the work is in an acceptable state or can be fixed
in no time.

When I run

game-data-packager baldurs-gate-1 setup_baldurs_gate_2.0.0.20.exe

I get this now:

game-data-packager baldurs-gate-1 setup_baldurs_gate_2.0.0.20.exe
INFO:game-data-packager:identifying setup_baldurs_gate_2.0.0.20.exe
WARNING:game-data-packager:found possible chitin.key
but its size does not match:
  file:
/mnt/data/gog/baldurs_gate_the_original_saga/gdptmp/gdptmp.qfsdo9pg/tmp/setup_baldurs_gate_2.0.0.20.exe.d/app/Chitin.key
  expected: 217559 bytes
  found   : 238496 bytes
INFO:game-data-packager:identifying
/mnt/data/gog/baldurs_gate_the_original_saga/gdptmp/gdptmp.qfsdo9pg/tmp/setup_baldurs_gate_2.0.0.20.exe.d/app/movies/MOVIECD1.BIF
INFO:game-data-packager:identifying
/mnt/data/gog/baldurs_gate_the_original_saga/gdptmp/gdptmp.qfsdo9pg/tmp/setup_baldurs_gate_2.0.0.20.exe.d/app/movies/MOVIECD4.BIF
WARNING:game-data-packager:found possible data/npcsound.bif
but its size does not match:


Apparently the files don't match, although I used the make-template
feature of g-d-p. It seems like innoextract runs are not reproducible...

Markus




-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20150929/60acb1ba/attachment.sig>