Bug#812695: pygame-sdl2: FTBFS: format not a string literal and no format arguments

[Gianfranco Costamagna]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

control: reopen -1
control: tags -1 patch

Hi, please revert the change, and sorry for breaking the API in the
libsdl2 2.0.4 upload

the correct fix comes from upstream, and it is included in the
following three commits
https://github.com/renpy/pygame_sdl2/commit/10b13b65173207d274ffa9570ec7
7a1aed6bc7e8
https://github.com/renpy/pygame_sdl2/commit/5605247b8b2c704238508a13bfc3
3b3e62dba852
https://github.com/renpy/pygame_sdl2/commit/c50dd46eb332c572349b02241014
911d5f23004c

or to sum them in a single patch file

- --- pygame-sdl2-6.99.8.orig/src/pygame_sdl2/error.pyx
+++ pygame-sdl2-6.99.8/src/pygame_sdl2/error.pyx
@@ -36,4 +36,4 @@ def get_error():

 def set_error(message):
     message = bytes(message)
- -    SDL_SetError(message)
+    SDL_SetError("%s", <char *>message)
- --- pygame-sdl2-6.99.8.orig/src/pygame_sdl2/rwobject.pyx
+++ pygame-sdl2-6.99.8/src/pygame_sdl2/rwobject.pyx
@@ -53,7 +53,7 @@ cdef set_error(e):
     cdef char *msg
     e = str(e)
     msg = <char *> e
- -    SDL_SetError(e)
+    SDL_SetError("%s", msg)

 cdef Sint64 python_size(SDL_RWops *context) with gil:
     f = <object> context.hidden.unknown.data1


sorry again for the break of your package!

cheers,

Gianfranco
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWqJg7AAoJEPNPCXROn13ZsHAP/jXofEhTMmAt0W9vwCUjb8Tj
NEeuGYVhseRORmOAZEfTu4AKUwUbP0q1lPrNPJY7iPsSRxwYKkwWo88KAKyfK56C
VtoSbEjV89Mayen1imQOpI71yGqRZKCaGZWACrWdlg71YFqRocDDE413lZWngEjv
ODsyZqKQt04spiUpU0/vTsRFak74e31ybBS4daFQKKPoHz2LS2zhrklUbjRj8ZxJ
IpMWoW/zLlNNXDdV7JD+Ay574oPYWuMdR4pzd6TFweZ/j4NYxts/1Cyi6c7NOI8e
bexnFWt+O/lggkAjt2VkhSC5v2X+TPFkYYl8Ira0qNzdrdTh/eg5g2UFu5FT0xGO
KnB/0tRJ0BcBAE2FgROcCpD29uTIMNDpGCY3hKJ/VhTNRm3N6yQ5Dxvrw/DH9zbQ
TQ5bIrzYoZH2FyqrpYOZjZR2G0gd9/El6phEiTWNMKrhvg6xUU7LWEGeeDJ/7WvE
cenC5Pk2cbXdjarHvLGAupGrxu8fx6Z46BvM16/HC2j/lKUdl4f8UpUiEQt1nND+
iJT6MbDBcqtfGLxwpSOLf4kjrJZ6aRhxus5nWRusKyojyZ2BATZiboXA5IlM16dt
EM3JyQRjOEz3vStmrP7FVGIeAEvKIpslXT3krl04riAHCbEWn8A078osPcVcp0SO
4R8YYN+fi4upVZm3zqNG
=YiHB
-----END PGP SIGNATURE-----