Bug#831205: mednafen: FTBFS with GCC 6: cdrom/CDAccess_CCD.cpp:349:20: error: call of overloaded 'abs(size_t)' is ambiguous

[Lucas Nussbaum]

Source: mednafen
Version: 0.9.38.7+dfsg-1
Severity: serious
Tags: stretch sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20160713 qa-ftbfs
Justification: FTBFS with GCC 6 on amd64

Hi,

During a rebuild of all packages in sid using the gcc-defaults package
available in experimental to make GCC default to version 6, your package failed
to build on amd64. For more information about GCC 6 and Stretch, see:
- https://wiki.debian.org/GCC6
- https://lists.debian.org/debian-devel-announce/2016/06/msg00007.html

Relevant part (hopefully):
> g++ -DLOCALEDIR=\"/usr/share/locale\" -DHAVE_CONFIG_H -I../include -I../include -I../intl   -Wdate-time -D_FORTIFY_SOURCE=2   -fsigned-char  -Wall -Wshadow -Wempty-body -Wignored-qualifiers -Wvla -Wvariadic-macros -Wdisabled-optimization  -fno-fast-math -fno-unsafe-math-optimizations -fno-aggressive-loop-optimizations -fomit-frame-pointer -fwrapv  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c -o cdrom/CDAccess_CCD.o cdrom/CDAccess_CCD.cpp
> cdrom/CDAccess_CCD.cpp: In member function 'void CDAccess_CCD::CheckSubQSanity()':
> cdrom/CDAccess_CCD.cpp:349:20: error: call of overloaded 'abs(size_t)' is ambiguous
>       if(abs(lba - s) > 100)
>                     ^
> In file included from /usr/include/c++/6/cstdlib:75:0,
>                  from /usr/include/c++/6/ext/string_conversions.h:41,
>                  from /usr/include/c++/6/bits/basic_string.h:5402,
>                  from /usr/include/c++/6/string:52,
>                  from /usr/include/c++/6/stdexcept:39,
>                  from /usr/include/c++/6/array:39,
>                  from /usr/include/c++/6/tuple:39,
>                  from /usr/include/c++/6/functional:55,
>                  from /usr/include/c++/6/memory:79,
>                  from cdrom/../types.h:22,
>                  from cdrom/../mednafen.h:4,
>                  from cdrom/CDAccess_CCD.cpp:18:
> /usr/include/stdlib.h:774:12: note: candidate: int abs(int)
>  extern int abs (int __x) __THROW __attribute__ ((__const__)) __wur;
>             ^~~
> In file included from /usr/include/c++/6/ext/string_conversions.h:41:0,
>                  from /usr/include/c++/6/bits/basic_string.h:5402,
>                  from /usr/include/c++/6/string:52,
>                  from /usr/include/c++/6/stdexcept:39,
>                  from /usr/include/c++/6/array:39,
>                  from /usr/include/c++/6/tuple:39,
>                  from /usr/include/c++/6/functional:55,
>                  from /usr/include/c++/6/memory:79,
>                  from cdrom/../types.h:22,
>                  from cdrom/../mednafen.h:4,
>                  from cdrom/CDAccess_CCD.cpp:18:
> /usr/include/c++/6/cstdlib:185:3: note: candidate: __int128 std::abs(__int128)
>    abs(__GLIBCXX_TYPE_INT_N_0 __x) { return __x >= 0 ? __x : -__x; }
>    ^~~
> /usr/include/c++/6/cstdlib:180:3: note: candidate: long long int std::abs(long long int)
>    abs(long long __x) { return __builtin_llabs (__x); }
>    ^~~
> /usr/include/c++/6/cstdlib:172:3: note: candidate: long int std::abs(long int)
>    abs(long __i) { return __builtin_labs(__i); }
>    ^~~
> make[4]: *** [cdrom/CDAccess_CCD.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2016/07/13/mednafen_0.9.38.7+dfsg-1_unstable_gcc6.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.