Bug#828625: nethack-console: wizard mode permanently identify does not works on armhf port

[James Cowgill]

Control: forwarded -1 devteam at nethack.org
Control: tags -1 pending

Hi,

On Sun, 2016-06-26 at 20:02 +0800, Mo Jun wrote:
> Package: nethack-console
> Version: 3.6.0-3
> Severity: normal
> Tags: patch
> 
> Dear Maintainer,
> 
> 1. This bug is only found on armhf port; it is not found on amd64 port.
>   It can be reproduced on a chroot Debian system on a ARMv7 smart phone
>   and on a full Debian system in a QEMU virtual machine.
[...]
>   When ^I is pressed in the Debug Identify menu, the identifier will be
>   returned by display_pickinv(). And wiz_identify() will check whether the
>   return value of display_pickinv() equals -1(src/cmd.c:595):
>        if (display_inventory((char *) 0, TRUE) == -1)
>   then determine to fully identify all items or do nothing.
> 
>   However the type char is unsigned by default on arm port. "any.a_char = -1;"
>   will set any.a_char to 255 actually on arm port(this can be verified
> by using gdb), so
>   that above if statement will never success, and the permanent wizard identify
>   will never be performed.

Your reasoning seems perfectly sound to me, and I can reproduce the bug
on one of Debian's armhf porterboxes. I've sent an email to the Nethack
devteam about this bug, and I'll upload your patch in a few moments.

Thanks a lot!
James
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20160626/734277b2/attachment.sig>