Bug#825492: Make build of documentation architecture-independent

Ghislain Vaillant ghisvail at gmail.com
Fri May 27 12:59:26 UTC 2016


On 27/05/16 12:38, James Cowgill wrote:
> Control: reassign -1 src:glfw3 3.1.2-3
> Control: severity -1 wishlist
> Control: tags -1 patch
>
> Hi,
>
> On Fri, 2016-05-27 at 10:09 +0100, Ghislain Vaillant wrote:
>> Package: glfw3
>> Version: 3.1.2-3
>>
>> Dear glfw3 maintainers,
>>
>> Whilst browsing the packaging of the glfw3 source package, I noticed
>> that the documentation was not built in an architecture-independent
>> way. I am forwarding a patch which addresses this.
>
> Thanks for the patch! I think it can be greatly simplified though.
>
> The glfw CMakeLists.txt contains a guard so that if doxygen is not
> found, it doesn't build the documentation so the dh_auto_configure line
> can be left as it.

Having an explicit GLFW_BUILD_DOCS=ON option + a guard in the build
system is a bit unusual. In this case, you are right the -arch / -indep
split can be dropped.

> I think the extra call to dh_doxygen is only needed if dot is used to
> generate graphs. This has been explicitly disabled in the CMakeLists.tt
> file.

Who knows what features dh_doxygen might get in the future though. I
don't think it hurts to have it. Besides nothing in the dh_doxygen
manpage explicitly states "for graphs only". Your call anyway.

> So I think the attached patch (which is the same as yours without the
> rules changes) should work. Does this seem reasonable?

Yep. Thanks for your work on glfw3.

Ghis



More information about the Pkg-games-devel mailing list