Bug#860393: Segfaults on startup

[Markus Koschany]

Control: tags -1 pending

On Mon, 17 Apr 2017 18:19:22 +0200 =?UTF-8?Q?Bernhard_=c3=9cbelacker?=
<bernhardu at mailbox.org> wrote:
> Hello,
> just tried if I can reproduce the issue.
> 
> I think this is a again a case of a pointer truncation by default
> int for a pointer returning function.
> 
> 
> First patch is just to build with debug information to make the
> automatic dbgsym packages helpful.
> 
> The second patch adds some includes to get prototypes for alloc function.
> This is also warned about in the current amd64 build log:
> ../win/proxy/nhext.c:36:39: warning: implicit declaration of function 'alloc' [-Wimplicit-function-declaration]
>      nhext_connection.in = (NhExtXdr *)alloc(sizeof(NhExtXdr));
>                                        ^~~~~
> 
> The third patch adds the prototype into a header file for nh_option_get_boolopt.
> 
> With these applied at least the user interface can start without crashing.
> The build shows another 58 "warning: implicit declaration of function", that
> may crash later.
> 

Hi,

thank you again for your analysis and your patches. I think this issue
was already reported upstream seven years ago [1] but since upstream
development stopped a while ago we haven't seen an update yet. I'm sure
if you were able to address the remaining issue a lot of people would
appreciate it. Nevertheless thanks for the patches so far, the GTK
version appears to be usable again and I have just uploaded a new revision.

Regards,

Markus

[1] https://sourceforge.net/p/slashem/bugs/955/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20170430/b3cfacba/attachment.sig>