Bug#871066: scummvm-tools: FTBFS: cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security]

[Lucas Nussbaum]

Source: scummvm-tools
Version: 1.9.0-1
Severity: serious
Tags: buster sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20170805 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> g++ -Wall -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -W -Wno-unused-parameter -Wno-empty-body -std=c++11  -Wno-long-long -Wno-multichar -Wno-unknown-pragmas -Wno-reorder -Wpointer-arith -Wcast-qual -Wshadow -Wnon-virtual-dtor -Wwrite-strings -fcheck-new -DHAVE_CONFIG_H -DPOSIX -I. -I.  -lboost_program_options  -Wl,-z,relro -Wl,-z,now -lm -I./decompiler/test/cxxtest -Wno-format -o decompiler/test/runner decompiler/test/runner.cpp common/file.o decompiler/codegen.o decompiler/control_flow.o decompiler/disassembler.o decompiler/instruction.o decompiler/simple_disassembler.o decompiler/value.o decompiler/scummv6/disassembler.o decompiler/scummv6/codegen.o decompiler/scummv6/engine.o decompiler/kyra/disassembler.o decompiler/kyra/codegen.o decompiler/kyra/engine.o decompiler/test/disassembler/pasc.o decompiler/test/disassembler/subopcode.o decompiler/unknown_opcode.o
> cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
> In file included from ./decompiler/instruction.h:32:0,
>                  from ./decompiler/graph.h:25,
>                  from ./decompiler/control_flow.h:25,
>                  from ./decompiler/test/cfg_test.h:24,
>                  from decompiler/test/runner.cpp:18:
> ./decompiler/value.h:93:31: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   virtual bool isSignedValue() throw(WrongTypeException);
>                                ^~~~~
> ./decompiler/value.h:101:28: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   virtual int32 getSigned() throw(WrongTypeException);
>                             ^~~~~
> ./decompiler/value.h:109:31: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   virtual uint32 getUnsigned() throw(WrongTypeException);
>                                ^~~~~
> ./decompiler/value.h:140:28: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   virtual ValuePtr negate() throw(WrongTypeException);
>                             ^~~~~
> ./decompiler/value.h:189:23: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   bool isSignedValue() throw(WrongTypeException);
>                        ^~~~~
> ./decompiler/value.h:190:20: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   int32 getSigned() throw(WrongTypeException);
>                     ^~~~~
> ./decompiler/value.h:191:23: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   uint32 getUnsigned() throw(WrongTypeException);
>                        ^~~~~
> ./decompiler/value.h:211:20: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   int32 getSigned() throw(WrongTypeException);
>                     ^~~~~
> In file included from ./decompiler/instruction.h:32:0,
>                  from ./decompiler/graph.h:25,
>                  from ./decompiler/control_flow.h:25,
>                  from ./decompiler/test/cfg_test.h:24,
>                  from decompiler/test/runner.cpp:18:
> ./decompiler/value.h:235:23: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   uint32 getUnsigned() throw(WrongTypeException);
>                        ^~~~~
> ./decompiler/value.h:338:28: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   virtual ValuePtr negate() throw(WrongTypeException);
>                             ^~~~~
> ./decompiler/value.h:380:28: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   virtual ValuePtr negate() throw(WrongTypeException);
>                             ^~~~~
> In file included from ./decompiler/engine.h:25:0,
>                  from ./decompiler/control_flow.h:26,
>                  from ./decompiler/test/cfg_test.h:24,
>                  from decompiler/test/runner.cpp:18:
> ./decompiler/disassembler.h:47:31: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   virtual void doDisassemble() throw(std::exception) = 0;
>                                ^~~~~
> In file included from ./decompiler/test/disassembler_test.h:24:0,
>                  from decompiler/test/runner.cpp:110:
> ./decompiler/test/disassembler/pasc.h:30:23: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   void doDisassemble() throw(std::exception);
>                        ^~~~~
> In file included from ./decompiler/test/disassembler_test.h:25:0,
>                  from decompiler/test/runner.cpp:110:
> ./decompiler/test/disassembler/subopcode.h:30:23: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   void doDisassemble() throw(std::exception);
>                        ^~~~~
> In file included from ./decompiler/test/disassembler_test.h:26:0,
>                  from decompiler/test/runner.cpp:110:
> ./decompiler/scummv6/disassembler.h:44:23: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
>   void doDisassemble() throw(std::exception);
>                        ^~~~~
> cc1plus: some warnings being treated as errors
> decompiler/test/module.mk:47: recipe for target 'decompiler/test/runner' failed
> make[1]: *** [decompiler/test/runner] Error 1

The full build log is available from:
   http://aws-logs.debian.net/2017/08/05/scummvm-tools_1.9.0-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.