Bug#871114: widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]

[Hans Joachim Desserud]

> Funny. It seems we worked on this bug at the same time. I can confirm
> that [2] resolved the FTBFS with GCC 7.

Looks like it. :) Thanks for uploading the patch and the other packaging
changes. (I've already picked it up and integrated it into the packaging
we do upstream for our PPA [1])

I've also added a short description and pointing to the backported patch
in the original GCC7-merge proposal for others who may come across it.

> I suggest to add a simple patch to bug reports
> next time which tremendously simplifies things for non-regular 
> uploaders
> of Widelands.

Yes, I considered adding a patch. The main reason I didn't is that I use
quilt too seldom to really remember how it works from time to time. So
I would need to look up the commands, which is not neccessarily hard, 
but
takes time and I knew I would be busy the following days. Since I didn't
know when I'd have the time to prepare a proper patch, I figuered I 
could
at least point to the existing patch, so that no one would need to add
GCC7 support from scratch. If it hadn't been picked up, I would have
prepared a patch when I got the time, but it seemed quicker to add a 
link
and let someone who knew the toolchain integrate it.

If I find the time, there will be a proper patch next time ;)

[1] https://code.launchpad.net/~hjd/widelands/debian-merge/+merge/329686

---
mvh / best regards
Hans Joachim Desserud
http://desserud.org