gdp yaml review

[Phil Morrell]

Thanks for checking, I didn't know about GDP_UNINSTALLED or
tools.check_equivalence, I'll use them for next time.
--
Phil Morrell (emorrp1)


On 14 September 2017 at 19:24, Alexandre Detiste
<alexandre.detiste at gmail.com> wrote:
> Hi,
>
> Seems really good, pushed to master
>
> We can compare each commit in a semi-automated way:
>
> $ git pull
> $ make
> $ cp out/vfs.zip ref.zip
> $ git checkout planescape-torment
> $ git pull (whoops, I wanted to check one commit at time)
> $ git reset --hard 45dadfbe00302d0bfc7c822a7469c5862fa8dcbb
> $ GDP_UNINSTALLED=1 python3 -m tools.check_equivalence planescape-torment |
> less
>
>        "name": "planescape-torment-en-data",
>        "optional": [
>          "autonote.ini",
>          "beast.ini",
> +        "ddrawfix/readme.html",    -> this is likely more related to the
> original DirectDraw engine
>                                                         than to the game
> scenario or assets; it doesn't hurt to keep ip tough
>          "keymap.ini",
>          "layout.ini",
> +        "manual.pdf",  --> nice
>          "override/ar0700.ini",
>          "override/ar0901.ini",
>          "quests.ini",
>          "readme.txt",
> +        "readme11.txt",   --> maybe a patch changelog,  locating the
> original from back then is nice for people
>                                             attempting to use the orignal
> media and not some already patched GOG/Steam version
>          "torment.ini"
>        ],
>
> Greets,
>
> 2017-09-14 18:44 GMT+02:00 Phil Morrell <debian at emorrp1.name>:
>>
>> Hi All,
>>
>> I've pushed a "planescape-torment" branch to the repo, please could
>> you review and merge the changes?
>>
>> This is the first time I've needed to create groups to bump the
>> archive version number, so I'm not confident I did it right - mainly
>> just followed the baldurs-gate diff.
>>
>> Thanks,
>> --
>> Phil Morrell (emorrp1)
>
>