Bug#1055799: minetest-server: installs minetest-server at .service twice once dh_installsystemd installs to /usr

[Helmut Grohne]

Source: minetest
Version: 5.6.1+dfsg+~1.9.0mt8+dfsg-3
Severity: normal
Tags: patch
User: helmutg at debian.org
Usertags: dep17m2

Hi Tobi,

thanks for fixing the nocheck FTBFS. This enables me to do QA on
minetest again! I'm preparing a debhelper update that makes
dh_installsystemd install systemd units below /usr in order to finalize
the /usr-merge transition via DEP17. Once doing that, minetest-server
will install minetest-server at .service to both /lib (via dh_install) and
/usr/lib (via dh_installsystemd). Doing so is a policy violation, so
this will become an rc bug once I upload debhelper. I'm attaching a
patch for your convenience. It can be readily applied and we can change
the location by a binNMU later.

Helmut
-------------- next part --------------
diff -Nru minetest-5.6.1+dfsg+~1.9.0mt8+dfsg/debian/changelog minetest-5.6.1+dfsg+~1.9.0mt8+dfsg/debian/changelog
--- minetest-5.6.1+dfsg+~1.9.0mt8+dfsg/debian/changelog	2023-11-11 11:43:28.000000000 +0100
+++ minetest-5.6.1+dfsg+~1.9.0mt8+dfsg/debian/changelog	2023-11-11 17:59:29.000000000 +0100
@@ -1,3 +1,11 @@
+minetest (5.6.1+dfsg+~1.9.0mt8+dfsg-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Install minetest-server at .service only once when dh_installsystemd
+    moves units to /usr. (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Sat, 11 Nov 2023 17:59:29 +0100
+
 minetest (5.6.1+dfsg+~1.9.0mt8+dfsg-3) unstable; urgency=medium
 
   * Team upload.
diff -Nru minetest-5.6.1+dfsg+~1.9.0mt8+dfsg/debian/minetest-server.install minetest-5.6.1+dfsg+~1.9.0mt8+dfsg/debian/minetest-server.install
--- minetest-5.6.1+dfsg+~1.9.0mt8+dfsg/debian/minetest-server.install	2022-09-15 19:52:10.000000000 +0200
+++ minetest-5.6.1+dfsg+~1.9.0mt8+dfsg/debian/minetest-server.install	2023-11-11 17:59:28.000000000 +0100
@@ -1,5 +1,4 @@
 debian/bin/minetestserver usr/games
-debian/minetest-server at .service lib/systemd/system
 debian/minetest.conf /etc/minetest
 usr/bin/minetestserver usr/lib/minetest
 usr/share/man/man6/minetestserver.6