<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>
<blockquote type="cite">
<pre class="message">to build with multiple versions of libminiupnpc-dev, replace </pre>
</blockquote>
I think your suggested replacement is a bit over the top. I don't
think there is any mileage in debian patches adding support for
very old versions of miniupnpc.</p>
<p>Also your suggested fix seems to have a couple of issues. Firstly
it seems to be missing a newline and secondly<br>
it seems to have a wrong variable name in it.<br>
<br>
Finally it seems that warzone2100 upstream was using the "API 14+"
version of the call. Debian then patched it to support the API
8-13 version of the call and broke support for API 14+.</p>
<p>So taking this all into account I whipped up a patch to support
both the API 14+ version of that call and the API 8-13 version but
not the older versions.<br>
<br>
Unfortunately after doing so it seems that the package still
failed to build in Raspbian buster, the next error was:<br>
</p>
<p>
<blockquote type="cite">netplay.cpp:978:106: error: too few
arguments to function ‘void* miniwget_getaddr(const char*, int*,
char*, int, unsigned int, int*)’                  <br>
   descXML = (char *)miniwget_getaddr(dev->descURL,
&descXMLsize, lanaddr, sizeof(lanaddr), dev->scope_id);</blockquote>
</p>
<p>Some searching lead me to
<a class="moz-txt-link-freetext" href="https://github.com/miniupnp/miniupnp/commit/c4991916e5c12a7754e935e71a5313e75af6aeb9#diff-9813014a8c763f65cfbd4caec9552ddd">https://github.com/miniupnp/miniupnp/commit/c4991916e5c12a7754e935e71a5313e75af6aeb9#diff-9813014a8c763f65cfbd4caec9552ddd</a>
and based on the changes to the testminiwget code in that commit I
whipped up a patch.</p>
<p>With these fixes I was able to get a succesful build in Raspbian
buster.<br>
</p>
<p>Debdiff attatched and uploaded to Raspbian, no intent to NMU in
Debian.<br>
</p>
</body>
</html>