Bug#265101: marked as done (LANG in /etc/environment does not take effect after reboot)

Debian Bug Tracking System owner@bugs.debian.org
Sun, 29 Aug 2004 22:33:10 -0700


Your message dated Mon, 30 Aug 2004 01:17:31 -0400
with message-id <E1C1eXr-0005kK-00@newraff.debian.org>
and subject line Bug#265101: fixed in gdm 2.6.0.4-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 11 Aug 2004 18:15:20 +0000
>From joey@kitenet.net Wed Aug 11 11:15:20 2004
Return-path: <joey@kitenet.net>
Received: from kitenet.net [64.62.161.42] (postfix)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BuxdA-0006X3-00; Wed, 11 Aug 2004 11:15:20 -0700
Received: from dragon.kitenet.net (unknown [66.168.94.144])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "Joey Hess", Issuer "Joey Hess" (verified OK))
	by kitenet.net (Postfix) with ESMTP id B39AE18D6D
	for <submit@bugs.debian.org>; Wed, 11 Aug 2004 18:10:21 +0000 (GMT)
Received: by dragon.kitenet.net (Postfix, from userid 1000)
	id 281146E872; Wed, 11 Aug 2004 15:10:34 -0300 (ART)
Date: Wed, 11 Aug 2004 15:10:34 -0300
From: Joey Hess <joeyh@debian.org>
To: submit@bugs.debian.org
Subject: LANG in /etc/environment does not take effect after reboot
Message-ID: <20040811181034.GA27893@kitenet.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga"
Content-Disposition: inline
X-Reportbug-Version: 2.63
User-Agent: Mutt/1.5.6+20040803i
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 


--opJtzjQTFsWo+cga
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Package: gdm
Version: 2.4.4.7-3
Severity: normal
Tags: d-i

Several Debian installation reports, including #264986 and #265016
mention a strange gdm behavior, which I have confirmed. These users
installed in non-English, and when base-config starts gdm for the first
time on the newly installed system, it comes up localised to their
language. However, when they reboot, gdm always comes up in English
thereafter.

I've investigated, and newly installed systems have a /etc/default/gdm
like this:

# GDM Defaults, source in the init script that starts GDM.  LANG
# setting is taken from the locales package by default.
LANG=3D
export LANG

(Aside: this export of LANG violates the strict letter of Debian policy
for defaults files. They are intended to only set variables, not export
them or call other shell commands. If you need LANG exported, it should
be exported in the init script after sourcing the defualts file.)

So there are two problems. First, the resulting "LANG=3D" unsets any
previously set value of LANG. Second, neither gdm nor its init script
seem to source /etc/environment to get the proper LANG setting as
provided by the installer.

I still don't understand why gdm is localised when it's started from
base-config. While base-config has exported LANG before running the init
script, I'd think the defaults file would unset it again, but it seems
to not.

I was able to get gdm to always come up localised by:

1. Commenting out the LANG settings in /etc/default/gdm.
2. Adding some lines near the top of /etc/init.d/gdm to source
   /etc/environment, and export LANG.

I suggest modifying the init.d script as described, and changing the
package to not write LANG=3D to /etc/default/gdm if it cannot get a LANG
setting from locales/default_environment_locale (which you won't, on a
fresh Debian install).

BTW, I looked at bug #133578, and IMHO, you just picked the wrong fix
for that bug entirely. locales is not the right source of default
language; /etc/environment is. I'd really recommend removing the changes
introduced to fix #133578, and just source /etc/environment as I
described. Ryan Murray's argument in
<20040417041342.GY13742@cyberhqz.com> seems wrong; /etc/environment
can be trivially parsed by sourcing it in the gdm init script, and gdm
*is* a login program, so sourcing /etc/environment is appropriate. But
this is only my opinion and I don't really care how you fix this bug. If
you would rather have d-i/base-config write a language setting to some
other file entirely, we could even do that.

And BTW, if this bug is not fixed soon (within a week), I will probably
start working around it in base-config. There are two workarounds I can
think of, the easiest is using kdm as the default greeter for new Debian
installs. Especially since gnome-session is *still* not fixed in
testing, so users already get KDE even when logging into gdm.

--=20
see shy jo

--opJtzjQTFsWo+cga
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBGmEad8HHehbQuO8RApLAAJ4uvNZtYo8ap3+WQyipTUVxEgNlzgCeOZi4
LiLsgVkKsmMf/ou11bSYRbY=
=ki1S
-----END PGP SIGNATURE-----

--opJtzjQTFsWo+cga--

---------------------------------------
Received: (at 265101-close) by bugs.debian.org; 30 Aug 2004 05:24:28 +0000
>From katie@ftp-master.debian.org Sun Aug 29 22:24:28 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1C1eea-0003Sy-00; Sun, 29 Aug 2004 22:24:28 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1C1eXr-0005kK-00; Mon, 30 Aug 2004 01:17:31 -0400
From: Ryan Murray <rmurray@debian.org>
To: 265101-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#265101: fixed in gdm 2.6.0.4-1
Message-Id: <E1C1eXr-0005kK-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Mon, 30 Aug 2004 01:17:31 -0400
Delivered-To: 265101-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Score: 7

Source: gdm
Source-Version: 2.6.0.4-1

We believe that the bug you reported is fixed in the latest version of
gdm, which is due to be installed in the Debian FTP archive:

gdm_2.6.0.4-1.diff.gz
  to pool/main/g/gdm/gdm_2.6.0.4-1.diff.gz
gdm_2.6.0.4-1.dsc
  to pool/main/g/gdm/gdm_2.6.0.4-1.dsc
gdm_2.6.0.4-1_i386.deb
  to pool/main/g/gdm/gdm_2.6.0.4-1_i386.deb
gdm_2.6.0.4.orig.tar.gz
  to pool/main/g/gdm/gdm_2.6.0.4.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 265101@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ryan Murray <rmurray@debian.org> (supplier of updated gdm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 29 Aug 2004 21:45:36 -0700
Source: gdm
Binary: gdm
Architecture: source i386
Version: 2.6.0.4-1
Distribution: unstable
Urgency: medium
Maintainer: Ryan Murray <rmurray@debian.org>
Changed-By: Ryan Murray <rmurray@debian.org>
Description: 
 gdm        - GNOME Display Manager
Closes: 248263 258213 258933 259173 261786 262625 265101 266734 267146
Changes: 
 gdm (2.6.0.4-1) unstable; urgency=medium
 .
   * New upstream release (closes: #258213)
   * When XKeepsCrashing uses whiptail, pass --scrolltext (closes: #248263)
   * Fix case typo in slave.c (closes: #259173)
   * Use invoke-rc.d in prerm (closes: #262625)
   * Don't export LANG in /etc/default/gdm (closes: #265101)
   * Move libexecdir to /usr/lib/gdm (closes: #266734)
   * Keep stderr open across some execs so error messages make it to the log
     (closes: #261786)
   * Update de.po, es.po (closes: #258933, #267146)
Files: 
 073d54c302a1f94b7dae36dd035f1733 719 gnome optional gdm_2.6.0.4-1.dsc
 8abac4da9cdaa21ca0a0bd03a42a7e19 5310026 gnome optional gdm_2.6.0.4.orig.tar.gz
 bc935bf6878dcf45b8fe6c5b59086fb0 58047 gnome optional gdm_2.6.0.4-1.diff.gz
 bba9df0f5b4315ab3a06268dd3cc0715 2976852 gnome optional gdm_2.6.0.4-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBMrLxN2Dbz/1mRasRAso1AJ9ygl36vnO4LGVfdHBg7ct+P+axkgCgpAGW
LVRaRHRZjypp3QW9aNvg7Oc=
=arzk
-----END PGP SIGNATURE-----