Bug#235903: marked as done (gnome-panel: Leaks X pixmap memory according to xrestop)

Debian Bug Tracking System owner@bugs.debian.org
Mon, 31 May 2004 11:33:09 -0700


Your message dated Mon, 31 May 2004 20:27:27 +0200
with message-id <sa78yf8fo4w.fsf@Elwing.coinnetwork.dl>
and subject line Fixed by GNOME 2.6 upload to unstable
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 3 Mar 2004 03:20:26 +0000
>From doug@ties.org Tue Mar 02 19:20:26 2004
Return-path: <doug@ties.org>
Received: from cpe-66-189-10-251.ma.charter.com (inigo.doug.ties.org) [66.189.10.251] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1AyMvq-00085G-00; Tue, 02 Mar 2004 19:20:26 -0800
Received: from deckard.doug.ties.org (deckard.doug.ties.org [192.168.1.8])
	by inigo.doug.ties.org (Postfix) with ESMTP
	id EC82DE18E; Tue,  2 Mar 2004 22:20:14 -0500 (EST)
Received: from doug by deckard.doug.ties.org with local (Exim 4.30)
	id 1AyMve-0000Vy-Pu; Tue, 02 Mar 2004 22:20:14 -0500
Content-Type: multipart/mixed; boundary="===============1231086104=="
MIME-Version: 1.0
From: Doug Larrick <doug@ties.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: gnome-panel: Leaks X pixmap memory according to xrestop
X-Mailer: reportbug 2.49
Date: Tue, 02 Mar 2004 22:20:14 -0500
Message-Id: <E1AyMve-0000Vy-Pu@deckard.doug.ties.org>
Sender: Doug Larrick <doug@deckard.doug.ties.org>
X-BadReturnPath: doug@jekyl.doug.ties.org rewritten as doug@ties.org
  using "From" header
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_01 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=HAS_PACKAGE autolearn=no 
	version=2.60-bugs.debian.org_2004_03_01
X-Spam-Level: 

This is a multi-part MIME message sent by reportbug.

--===============1231086104==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: gnome-panel
Version: 2.4.2-3
Severity: normal
Tags: patch

The GNOME panel leaks X pixmap memory if its background is set to 
"transparent".  The X server's memory usage on a busy system can grow
extensively on a busy system over a period of days, running it out of 
swap space.

Upstream has fixed this problem in their CVS, but is not planning to 
release a fix for GNOME 2.4.  I believe the fix is simple and important
enough to belong in the Debian package.

See http://bugzilla.gnome.org/show_bug.cgi?id=129855 for details, 
including the patch (which I will also attempt to include here).


-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing'), (50, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.3
Locale: LANG=C, LC_CTYPE=C

Versions of packages gnome-panel depends on:
ii  gnome-control-center        1:2.4.0-5    The GNOME Control Center for GNOME
ii  gnome-desktop-data          2.4.1-6      Common files for GNOME 2 desktop a
ii  gnome-panel-data            2.4.2-3      Common files for GNOME 2 panel
ii  gnome-session               2.4.2-1      The GNOME 2 Session Manager
ii  libart-2.0-2                2.3.16-1     Library of functions for 2D graphi
ii  libatk1.0-0                 1.4.1-1      The ATK accessibility toolkit
ii  libaudiofile0               0.2.3-4      The Audiofile Library
ii  libbonobo2-0                2.4.3-1      Bonobo CORBA interfaces library
ii  libbonoboui2-0              2.4.3-2      The Bonobo UI library
ii  libc6                       2.3.2.ds1-11 GNU C Library: Shared libraries an
ii  libesd-alsa0 [libesd0]      0.2.29-1     Enlightened Sound Daemon (ALSA) - 
ii  libgconf2-4                 2.4.0.1-4    GNOME configuration database syste
ii  libgcrypt1                  1.1.12-4     LGPL Crypto library - runtime libr
ii  libglade2-0                 2.0.1-6      Library to load .glade files at ru
ii  libglib2.0-0                2.2.3-1      The GLib library of C routines
ii  libgnome-desktop-2          2.4.1-6      Utility library for loading .deskt
ii  libgnome2-0                 2.4.0-4      The GNOME 2 library - runtime file
ii  libgnomecanvas2-0           2.4.0-1      A powerful object-oriented display
ii  libgnomeui-0                2.4.0.1-6    The GNOME 2 libraries (User Interf
ii  libgnomevfs2-0              2.4.1-4.1    The GNOME virtual file-system libr
ii  libgnomevfs2-common         2.4.1-4.1    The GNOME virtual file-system libr
ii  libgnutls7                  0.8.12-5     GNU TLS library - runtime library
ii  libgtk2.0-0                 2.2.4-3      The GTK+ graphical user interface 
ii  libice6                     4.3.0-2      Inter-Client Exchange library
ii  libjpeg62                   6b-9         The Independent JPEG Group's JPEG 
ii  liborbit2                   1:2.8.3-2    libraries for ORBit2 - a CORBA ORB
ii  libpanel-applet2-0          2.4.2-3      Library for GNOME 2 Panel applets
ii  libpango1.0-0               1.2.5-2.1    Layout and rendering of internatio
ii  libpng12-0                  1.2.5.0-5    PNG library - runtime
ii  libpopt0                    1.7-4        lib for parsing cmdline parameters
ii  libsm6                      4.3.0-3      X Window System Session Management
ii  libstartup-notification0    0.5-4        library for program launch feedbac
ii  libtasn1-0                  0.1.2-1      Manage ASN.1 structures (runtime)
ii  libwnck4                    2.4.0.1-2    Window Navigator Construction Kit 
ii  libx11-6                    4.3.0-3      X Window System protocol client li
ii  libxext6                    4.3.0-3      X Window System miscellaneous exte
ii  libxml2                     2.6.6-1      GNOME XML library
ii  xlibs                       4.3.0-3      X Window System client libraries m
ii  zlib1g                      1:1.2.1-4    compression library - runtime

-- no debconf information

--===============1231086104==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="leak.diff"

Index: panel-background.c
===================================================================
RCS file: /cvs/gnome/gnome-panel/gnome-panel/panel-background.c,v
retrieving revision 1.11.2.1
diff -u -p -r1.11.2.1 panel-background.c
--- panel-background.c	19 Sep 2003 23:45:24 -0000	1.11.2.1
+++ panel-background.c	22 Dec 2003 18:25:29 -0000
@@ -45,7 +45,11 @@ free_prepared_resources (PanelBackground
 	case PANEL_BACK_NONE:
 		break;
 	case PANEL_BACK_COLOR:
-		if (!background->has_alpha) {
+		if (background->has_alpha) {
+			if (background->pixmap)
+				g_object_unref (background->pixmap);
+			background->pixmap = NULL;
+		} else {
 			if (background->colormap && background->color.gdk.pixel)
 				gdk_colormap_free_colors (
 					background->colormap,

--===============1231086104==--

---------------------------------------
Received: (at 235903-done) by bugs.debian.org; 31 May 2004 18:28:11 +0000
>From Duck@duckcorp.org Mon May 31 11:28:11 2004
Return-path: <Duck@duckcorp.org>
Received: from home.duckcorp.org (mx.duckcorp.org) [62.4.22.189] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BUrW6-0004vT-00; Mon, 31 May 2004 11:28:10 -0700
Received: from localhost (localhost [127.0.0.1])
	by mx.duckcorp.org (Postfix) with ESMTP
	id C666D14C74F; Mon, 31 May 2004 20:27:38 +0200 (CEST)
Received: from mx.duckcorp.org ([127.0.0.1])
	by localhost (Elwing [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 32310-09; Mon, 31 May 2004 20:27:31 +0200 (CEST)
Received: from Elwing.coinnetwork.dl (localhost [127.0.0.1])
	by mx.duckcorp.org (Postfix) with ESMTP
	id 282B114C74D; Mon, 31 May 2004 20:27:31 +0200 (CEST)
From: =?utf-8?q?Marc_Dequ=C3=A8nes?= (Duck) <Duck@DuckCorp.org>
To: 242074-done@bugs.debian.org, 186484-done@bugs.debian.org,
	235903-done@bugs.debian.org, 216577-done@bugs.debian.org,
	249906-done@bugs.debian.org, 238862-done@bugs.debian.org,
	242258-done@bugs.debian.org, 250807-done@bugs.debian.org
Subject: Fixed by GNOME 2.6 upload to unstable
Organization: DuckCorp
Date: Mon, 31 May 2004 20:27:27 +0200
Message-ID: <sa78yf8fo4w.fsf@Elwing.coinnetwork.dl>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
X-Virus-Scanned: by Amavis at CoinNetwork
Delivered-To: 235903-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
	version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Score: 3

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


These bugs were not closed by upload because of manual tagging.
They are closed by new packages from experimental recently uploaded into
sid.

And thx to the GNOME Team Core members for managing this upload very
well.

=2D-=20
Marc Dequ=C3=A8nes (Duck)

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAu3kSsczZcpAmcIYRAnT1AKCONweSeD5oqAqVX1BvZHiF/Rs97QCgqK+7
UHqfsrAPMA5v0WrQiSzAcm8=
=OnDm
-----END PGP SIGNATURE-----
--=-=-=--