Bug#272921: marked as done (55gnome-session_gnomerc doesn't work when gnome-session is run with arguments)

Debian Bug Tracking System owner@bugs.debian.org
Thu, 21 Oct 2004 14:18:08 -0700


Your message dated Thu, 21 Oct 2004 17:02:17 -0400
with message-id <E1CKk4f-0004Me-00@newraff.debian.org>
and subject line Bug#272921: fixed in gnome-session 2.6.2-6
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 22 Sep 2004 20:12:26 +0000
>From andrei.badea@movzx.net Wed Sep 22 13:12:26 2004
Return-path: <andrei.badea@movzx.net>
Received: from smtp.nextra.cz [195.70.130.2] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CADTV-0003ey-00; Wed, 22 Sep 2004 13:12:26 -0700
Received: from [192.168.1.2] (194.149.100.222.adsl.nextra.cz [194.149.100.222])
	by smtp.nextra.cz (Postfix) with ESMTP id CBE565DC0
	for <submit@bugs.debian.org>; Wed, 22 Sep 2004 22:12:23 +0200 (CEST)
Message-ID: <4151DCB0.907@movzx.net>
Date: Wed, 22 Sep 2004 22:12:32 +0200
From: Andrei Badea <andrei.badea@movzx.net>
User-Agent: Mozilla Thunderbird 0.8 (X11/20040913)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: submit@bugs.debian.org
Subject: 55gnome-session_gnomerc doesn't work when gnome-session is run with
 arguments
X-Enigmail-Version: 0.86.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=ISO-8859-2; format=flowed
Content-Transfer-Encoding: 7bit
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Package: gnome-session
Version: 2.6.2-5

The /etc/X11/Xsession.d/55gnome-session_gnomerc script doesn't work correctly 
when gnome-session is run with arguments (such as in "gnome-session 
--purge-delay 3000").

Running gnome-session with arguments causes this error message:

/etc/X11/Xsession.d/55gnome-session_gnomerc: line 3: [: too many arguments

To reproduce (using GDM):

1) change /usr/share/xsessions/gnome.desktop to run gnome-session with at least 
one argument
2) login into a Gnome session
3) the error message can be found in ~/.xsession-errors. Also the ~/.gnomerc 
file (if it exists) is not executed

This happens because the code in 55gnome-session_gnomerc that gets the file name 
from the STARTUP variable doesn't account for possible arguments in STARTUP.

A simple (and not perfect) way to solve this is to delete all characters after 
the first space (including). I'm attaching a patch:

--- 55gnome-session_gnomerc     2004-04-22 11:19:28.000000000 +0200
+++ 55gnome-session_gnomerc.new 2004-09-22 21:51:40.000000000 +0200
@@ -1,7 +1,7 @@
  # If we are running the GNOME session, source ~/.gnomerc

-if [ `basename "$STARTUP"` = gnome-session -o \
-       \( `basename "$STARTUP"` = x-session-manager -a \
+if [ `basename "${STARTUP/ */}"` = gnome-session -o \
+       \( `basename "${STARTUP/ */}"` = x-session-manager -a \
         `readlink /etc/alternatives/x-session-manager` = \
                 /usr/bin/gnome-session \) ]; then
    GNOMERC=$HOME/.gnomerc

Best regards,
Andrei

-- 
andrei.badea@movzx.net # http://movzx.net # ICQ: 52641547


---------------------------------------
Received: (at 272921-close) by bugs.debian.org; 21 Oct 2004 21:09:28 +0000
>From katie@ftp-master.debian.org Thu Oct 21 14:09:28 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CKkBc-0005b4-00; Thu, 21 Oct 2004 14:09:28 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1CKk4f-0004Me-00; Thu, 21 Oct 2004 17:02:17 -0400
From: Josselin Mouette <joss@debian.org>
To: 272921-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#272921: fixed in gnome-session 2.6.2-6
Message-Id: <E1CKk4f-0004Me-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Thu, 21 Oct 2004 17:02:17 -0400
Delivered-To: 272921-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Score: 5

Source: gnome-session
Source-Version: 2.6.2-6

We believe that the bug you reported is fixed in the latest version of
gnome-session, which is due to be installed in the Debian FTP archive:

gnome-session_2.6.2-6.diff.gz
  to pool/main/g/gnome-session/gnome-session_2.6.2-6.diff.gz
gnome-session_2.6.2-6.dsc
  to pool/main/g/gnome-session/gnome-session_2.6.2-6.dsc
gnome-session_2.6.2-6_i386.deb
  to pool/main/g/gnome-session/gnome-session_2.6.2-6_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 272921@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Josselin Mouette <joss@debian.org> (supplier of updated gnome-session package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 21 Oct 2004 22:27:36 +0200
Source: gnome-session
Binary: gnome-session
Architecture: source i386
Version: 2.6.2-6
Distribution: unstable
Urgency: low
Maintainer: Josselin Mouette <joss@debian.org>
Changed-By: Josselin Mouette <joss@debian.org>
Description: 
 gnome-session - The GNOME 2 Session Manager
Closes: 234653 267121 272921 275574 275575
Changes: 
 gnome-session (2.6.2-6) unstable; urgency=low
 .
   * 02_conversion.diff: only print a warning, don't launch the broken upgrade
     script (closes: #275574, #234653).
   * patches/05_debian_gnome_upgrade_check.diff, gnome-1-to-2,
     gnome-launchers-1-to-2, gnome-panel-1-to-2, gnome-stuff-1-to-2,
     nautilus-666666.desktop: removed.
   * gnome-session.install: don't install those.
   * rules: don't have to fix the permissions.
   * control.in:
     + Depend on capplets (closes: #275575, #267121).
     + Recommend nautilus, gnome-panel and a window manager.
   * 55gnome-session_gnomerc: support arguments to gnome-session
     (closes: #272921).
   * 00_Makefile.am.diff: removed.
   * 01_autoreconf.diff: updated.
Files: 
 5c08ac9fe0144f1c17c99f3f2b72dbdd 1665 gnome optional gnome-session_2.6.2-6.dsc
 cf55bcaabdd4ed2ae4987796107deb86 101897 gnome optional gnome-session_2.6.2-6.diff.gz
 26c1e8f107babb08f7f677cb4c8c779b 445888 gnome optional gnome-session_2.6.2-6_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBeB7frSla4ddfhTMRAitnAKC8edvtvilEzeprJcOhKbBePjQrlgCfeo1r
ORNFzxBs7Hn9IeDLgwZQBUA=
=HDZS
-----END PGP SIGNATURE-----