Bug#334450: Review of proposed stable changes

[Martin Schulze]

Loic Minier wrote:
>         Hi,
> 
>  I'm willing to do a stable-proposed-updates upload of
>  libgnomeprint2.2-0 to address #334450.  It is an important usability
>  bug, but I know that important bugs can not always be addressed in
>  stable.  Joey: please check the severity of #334450 and the length of
>  the patch and tell me whether you would accept such an upload to SPU.

If I understand the problem correctly, for some reason libgnomeprint does
not use the proper lpr command.  However, the patch does not implicate
the execution location.

Let's take a look at the patch:

+#if !defined(HAVE_POPEN)
+#ifdef G_OS_WIN32
+#include <stdio.h>
+#define popen(f,m) _popen(f,m)
+#endif
+#endif
+
+#if !defined(HAVE_PCLOSE)
+#ifdef G_OS_WIN32
+#include <stdio.h>
+#define pclose(f) _pclose(f)
+#endif
+#endif
+

Redefining popen/pclose to internal routines.  Why?

-       tcustom->pipe = popen (command, "wb");
+       tcustom->pipe = popen (command,
+#ifdef G_OS_WIN32
+               "wb"
+#else
+               "w"
+#endif

Taking care of windows.  No thanks.

-#if !defined(HAVE_CLOSE)
+#if !defined(HAVE_PLOSE)

Turning a valid ifdef into an invalid one.  Don't look suited for me.

Please explain.

Regards,

	Joey

-- 
MIME - broken solution for a broken design.  -- Ralf Baechle

Please always Cc to me when replying to me on the lists.