Bug#395994: vino: CoRRE encoding broken in version 2.13.5-3 and 2.16.0-1

[Detlef Schmicker]

Hi Loic,

sorry for the "bad" bug report. It was my first one to debian. I managed
to apply your patch and it works. 

There is a minor issue upgrading from 2.13.5-3 to 2.16.0-2: 
 - Authorization with password is not working after upgrade.

One first has to reassign the password in the gnome remote desktop
settings. I think I observed the same behaviour before upgrading to
2.16.0-1.

Thanks a lot for your patience.

Detlef



Am Sonntag, den 29.10.2006, 22:23 +0100 schrieb Loïc Minier:
> found 395994 2.13.5-3
> found 395994 2.16.0-1
> tags 395994 + upstream confirmed fixed-upstream patch
> stop
> 
>         Hi,
> 
> On Sun, Oct 29, 2006, Detlef Schmicker wrote:
> > Version: 2.13.5-4cvs
> 
>  Please fix the version of your bug report before sending it or it wont
>  be closed properly.
> 
> > The CoRRE encoding is broken. It was fixed in the gnome/vino cvs around 
> > 18. Oct 06. Please include this fix.
> 
>  Thanks for the report; it would really be nice (perhaps for your next
>  reports) to:
>  - attach a patch
>  - and/or point to the upstream commits/CVS interface with the changes
>  - and/or point to the upstream bug #
> 
>  Could you please test the attached patch and tell me whether it is
>  enough?  There were other fixes around the same date on the same file,
>  so I picked these two commits:
> 
> ----------------------------
> revision 1.6
> date: 2006/10/18 08:24:49;  author: markmc;  state: Exp;  lines: +68 -122
> 2006-10-18  Mark McLoughlin  <mark at skynet.ie>
> 
>         * server/libvncserver/rfbserver.c: cherry-pick some more
>         fixes from upstream libvncserver.
> ----------------------------
> revision 1.5
> date: 2006/10/18 08:24:30;  author: markmc;  state: Exp;  lines: +6 -0
> 2006-10-18  Mark McLoughlin  <mark at skynet.ie>
> 
>         Fix issue with the CoRRE encoding saying its only sending
>         a single rectangle, but sending lots more. Problem identified
>         by Detlef Schmicker <d.schmicker at physik.de>
> 
>         Fix is backported from libvncserver upstream.
> 
>         * server/libvncserver/rfbserver.c:
>         (rfbSendFramebufferUpdate): handle maxRectsPerUpdate for
>         CoRRE and Zlib encodings.
> 
>  Perhaps the cherry-picking part isn't needed, but if this patch works
>  for you, I'll keep it.
> 
>    Thanks in advance,
-- 
Detlef Schmicker <d.schmicker at physik.de>