Bug#449144: tsclient: Please add RDPv5 disk mapping support (patch available)

Kilian Krause kilian at debian.org
Mon Nov 5 22:22:51 UTC 2007


Clement,

On Mon, Nov 05, 2007 at 07:12:40PM +0100, Clement 'nodens' Hermann wrote:
> Oops... wrong patch...
> 
> the good one is attached.

Thanks. Let's get started reviewing.


> Clement 'nodens' Hermann a écrit :
> >Hi all,
> >
> >Here is the patch against 0.148 source.
> >
> >The source package is available on  
> >http://clement.hermann.free.fr/debian/tsclient/ along with binary 
> >builds for i386 and amd64.
> >
> >I'm not familiar with the gnome packaging team methods (uploaders and 
> >such) and did my best to do it "the gnome packaging way" without 
> >understanding everything involved (uploaders and such), so  please 
> >correct whatever I did wrong.

ok, let's start with the obvious. The Debian packaging of tsclient is
supposed to be the debian/ dir only. I.e. if you have a new upstream
source, there is no need to patch the full source to the new version and
mail that as diff. You just include the new tarball version for that
release in debian/changelog and make the neccessary adjustments in debian/.
Most commonly it's a good idea to add a get-orig-source target for this
- or to plain use it if it's there already. ;)

Second you included automake1.9 and autoconf in the Build-Deps. That
generally is a *very good* indication for things that have gone utterly
wrong. For a proper packaging you should not regenerate the configure
during the build to keep a certain amount of reproducability. That's the
reason there was a patch for that update to make the outcome rather
predictable. Maintainer mode is for developers, not for packagers. ;)

Moreover if you drop patches, it's always nice to know why this is no
longer needed (added included upstream for that reason).

Thirdly, the SVN was a bit further, so your patch didn't really apply
cleanly. I have manually fixed that part. 

The result with some slight modifications to get the package mostly
lintian clean I have put in SVN[1].

Can you verify this is the intended result so I can go and upload it?
Thanks!

-- 
Best regards,
Kilian

[1]:
http://svn.debian.org/wsvn/pkg-gnome/packages/unstable/tsclient?op=log
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20071105/e19d0148/attachment-0001.pgp 


More information about the pkg-gnome-maintainers mailing list