[Bug 132808] History/bookmarks columns bugs

[epiphany (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=132808

  epiphany | History | Ver: 1.9.x

Kristian Rietveld changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kris at gtk.org




------- Comment #22 from Kristian Rietveld  2007-11-13 17:57 UTC -------
Cosimo queried me about this on IRC this afternoon.  As I have never seen this
before I started out by suspected EphyNodeView ;)  When I quickly read over
that code I saw some button-press handlers connected to the GtkTreeView.  These
were not checking on which window the events were received -- this stroke me as
very suspicious.  As I was not on a Linux machine this afternoon I could not
verify this until now.  And it seems that my first suspicion is right ;)

If I patch EphyNodeView with the following, the problem goes away for me:

 Index: ephy-node-view.c
===================================================================
--- ephy-node-view.c    (revision 7685)
+++ ephy-node-view.c    (working copy)
@@ -812,6 +812,12 @@ ephy_node_view_button_press_cb (GtkWidge
        gboolean call_parent = TRUE, path_is_selected;
        selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (treeview));

+
+       if (event->window != gtk_tree_view_get_bin_window (GTK_TREE_VIEW
(treeview)))
+       {
+               return GTK_WIDGET_CLASS (parent_class)->button_press_event
(treeview, event);
+       }
+
        if (gtk_tree_view_get_path_at_pos (GTK_TREE_VIEW (treeview),
                                           event->x,
                                           event->y,


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=132808.