Bug#442148: hardening Xsession of gdm to detect incorrect Xsession.d scripts for example

[Alban Browaeys]

Package: gdm
Version: 2.18.4-1
Severity: wishlist
Tags: patch

Attached is a patch that put /etc/gdm/Xsession on par with
/etc/X11/Xsession (set -e) . I find it really usefull as it detects if
something is wrong in the STARTUP variable while it is exec by
99x11-common_start . This happened to me that seahorse xsession script
was (is still) broken and it went undetected preventing the other
executable in this variable from working soon enough for the gnome-panel
(dbus for example was not available to the applets).

Best regards,
Alban

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-2-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages gdm depends on:
ii  adduser                    3.105         add and remove users and groups
ii  debconf [debconf-2.0]      1.5.14        Debian configuration management sy
ii  gksu                       2.0.0-4       graphical frontend to su
ii  gnome-session              2.18.3-1      The GNOME 2 Session Manager
ii  gnome-terminal [x-terminal 2.18.1-1      The GNOME 2 terminal emulator appl
ii  konsole [x-terminal-emulat 4:3.5.7-3     X terminal emulator for KDE
ii  kwin [x-window-manager]    4:3.5.7-3     the KDE window manager
ii  libart-2.0-2               2.3.19-3      Library of functions for 2D graphi
ii  libatk1.0-0                1.18.0-2      The ATK accessibility toolkit
ii  libattr1                   1:2.4.32-1.2  Extended attribute shared library
ii  libc6                      2.6.1-3       GNU C Library: Shared libraries
ii  libcairo2                  1.4.10-1      The Cairo 2D vector graphics libra
ii  libdbus-1-3                1.1.1-3       simple interprocess messaging syst
ii  libdbus-glib-1-2           0.74-1        simple interprocess messaging syst
ii  libdmx1                    1:1.0.2-2     X11 Distributed Multihead extensio
ii  libfontconfig1             2.4.2-1.2     generic font configuration library
ii  libglade2-0                1:2.6.2-1     library to load .glade files at ru
ii  libglib2.0-0               2.14.0-2      The GLib library of C routines
ii  libgnomecanvas2-0          2.14.0-3      A powerful object-oriented display
ii  libgtk2.0-0                2.10.13-1     The GTK+ graphical user interface 
ii  libpam-modules             0.99.7.1-4    Pluggable Authentication Modules f
ii  libpam-runtime             0.99.7.1-4    Runtime support for the PAM librar
ii  libpam0g                   0.99.7.1-4    Pluggable Authentication Modules l
ii  libpango1.0-0              1.18.1-1      Layout and rendering of internatio
ii  libpopt0                   1.10-3        lib for parsing cmdline parameters
ii  librsvg2-2                 2.18.2-1      SAX-based renderer library for SVG
ii  librsvg2-common            2.18.2-1      SAX-based renderer library for SVG
ii  libselinux1                2.0.15-2+b1   SELinux shared libraries
ii  libwrap0                   7.6.dbs-14    Wietse Venema's TCP wrappers libra
ii  libx11-6                   2:1.0.3-7     X11 client-side library
ii  libxau6                    1:1.0.3-2     X11 authorisation library
ii  libxcursor1                1:1.1.9-1     X cursor management library
ii  libxdmcp6                  1:1.0.2-2     X11 Display Manager Control Protoc
ii  libxext6                   1:1.0.3-2     X11 miscellaneous extension librar
ii  libxfixes3                 1:4.0.3-2     X11 miscellaneous 'fixes' extensio
ii  libxi6                     2:1.1.3-1     X11 Input extension library
ii  libxinerama1               1:1.0.2-1     X11 Xinerama extension library
ii  libxml2                    2.6.30.dfsg-2 GNOME XML library
ii  libxrandr2                 2:1.2.2-1     X11 RandR extension library
ii  libxrender1                1:0.9.3-1     X Rendering Extension client libra
ii  lsb-base                   3.1-24        Linux Standard Base 3.1 init scrip
ii  metacity [x-window-manager 1:2.18.5-1    A lightweight GTK2 based Window Ma
ii  sawfish [x-window-manager] 1:1.3.1-1     a window manager for X11
ii  twm [x-window-manager]     1:1.0.3-2     Tab window manager
ii  xbase-clients              1:7.2.ds2-2   miscellaneous X clients
ii  xterm [x-terminal-emulator 229-1         X terminal emulator

Versions of packages gdm recommends:
ii  dialog                 1.1-20070604-1    Displays user-friendly dialog boxe
ii  gdm-themes             0.5.1             Themes for the GNOME Display Manag
ii  whiptail               0.52.2-11         Displays user-friendly dialog boxe
ii  xserver-xephyr         2:1.3.0.0.dfsg-12 Next Generation Nested X Server
ii  zenity                 2.18.2-1          Display graphical dialog boxes fro

-- debconf-show failed
-------------- next part --------------
25a26
> set -e
122,123c123,124
< zenity=`which zenity 2>/dev/null`
< xmessage=`which xmessage 2>/dev/null`
---
> zenity=`which zenity 2>/dev/null` || true
> xmessage=`which xmessage 2>/dev/null` || true
141c142
< freetemp=`which freetemp 2>/dev/null`
---
> freetemp=`which freetemp 2>/dev/null` || true