r14643 - in /packages/unstable/libgnomedb3/debian: changelog control control.in

[Loïc Minier]

On Sun, Feb 17, 2008, grm-guest at users.alioth.debian.org wrote:
> debian/control.in: Added DM-Upload-Allowed field

 I wanted to sponsor this immediately, but libgnomedb3 fails to build in
 pbuilder for me:
LC_ALL=C ../../intltool-merge -x -u -c ../../po/.intltool-merge-cache ../../po gnome-db-entry-string-string.xml.in gnome-db-entry-string-string.xml
Possible unintended interpolation of @INTLTOOL_ICONV in string at ../../intltool-merge line 96.
Global symbol "@INTLTOOL_ICONV" requires explicit package name at ../../intltool-merge line 96.
BEGIN not safe after errors--compilation aborted at ../../intltool-merge line 263.
make[3]: *** [gnome-db-entry-string-string.xml] Error 9
make[3]: Leaving directory `/tmp/buildd/libgnomedb3-3.0.0/libgnomedb/data-entries'
make[2]: *** [all-recursive] Error 1

 It looks like @INTLTOOL_ICONV@ isn't properly expanded in:
my $iconv = $ENV{"ICONV"} || $ENV{"INTLTOOL_ICONV"} || "@INTLTOOL_ICONV@";

 This is typically caused by mixing old intltool m4 macros with new
 intltool files or vice versa; this can be exacerbated by a copy of
 intltool.m4 in the package.

 I wonder why we didn't see this earlier, but this is certainly made
 more visible by the abscence of AM_MAINTAINER_MODE in upstream's
 configure.in which causes an autoconf run:
cd . && CC="cc" CXX="g++" CFLAGS="-g -Wall -O2" CXXFLAGS="-g -Wall -O2" CPPFLAGS="" LDFLAGS="-Wl,-z,defs -Wl,-O1 -Wl,--as-needed" /tmp/buildd/libgnomedb3-3.0.0/./configure --build=i486-linux-gnu --prefix=/usr --includedir="\${prefix}/include" --mandir="\${prefix}/share/man" --infodir="\${prefix}/share/info" --sysconfdir=/etc --localstatedir=/var --libexecdir="\${prefix}/lib/libgnomedb3" --disable-maintainer-mode --disable-dependency-tracking --srcdir=.   --enable-gtk-doc
checking for a BSD-compatible install... /usr/bin/install -c
...
      Maemo platform= no

GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1 /usr/bin/make -C .
make[1]: Entering directory `/tmp/buildd/libgnomedb3-3.0.0'
cd . && /bin/sh /tmp/buildd/libgnomedb3-3.0.0/missing --run aclocal-1.9
 cd . && /bin/sh /tmp/buildd/libgnomedb3-3.0.0/missing --run automake-1.9 --gnu
cd . && /bin/sh /tmp/buildd/libgnomedb3-3.0.0/missing --run autoconf
/bin/sh ./config.status --recheck
running CONFIG_SHELL=/bin/sh /bin/sh /tmp/buildd/libgnomedb3-3.0.0/./configure  --build=i486-linux-gnu --prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man --infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --libexecdir=${prefix}/lib/libgnomedb3 --disable-maintainer-mode --disable-dependency-tracking --srcdir=. --enable-gtk-doc build_alias=i486-linux-gnu CC=cc CFLAGS=-g -Wall -O2 LDFLAGS=-Wl,-z,defs -Wl,-O1 -Wl,--as-needed CPPFLAGS= CXX=g++ CXXFLAGS=-g -Wall -O2  --no-create --no-recursion
checking for a BSD-compatible install... /usr/bin/install -c
...

 I am not 100% sure why autoconf is triggerred here, perhaps you should
 have run aclocal.

 I would highly recommend to ask upstream to add AM_MAINTAINER_MODE as
 it's quite easy to break our builds because of timestamp skews, also
 I think you should updated your autotools patch to also:
 - libtoolize
 - aclocal
 - intltoolize
 also, move your relibtoolize patches to the end of the patch stack (I
 often use 70_) as to make sure they get applied after any patch against
 autotools sources (configure.in or Makefile.am for instance).

   Thanks,
-- 
Loïc Minier